Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transmission-cli: add livecheck strategy #64426

Merged

Conversation

samford
Copy link
Member

@samford samford commented Nov 9, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Currently, livecheck uses the PageMatch strategy for the GitHub repository URL used in the transmission-cli livecheck block, since the Git strategy doesn't apply to it. We check the main GitHub page for this project because this repository simply contains archive files.

The Git strategy will apply to this URL if/when Homebrew/brew#9074 is merged, so I'm preemptively specifying the strategy here to prevent this check from breaking. This check is already using the PageMatch strategy, so this doesn't alter the current behavior and there's no harm in defensively adding it here.

@samford samford added livecheck Issues or PRs related to livecheck CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Nov 9, 2020
@BrewTestBot BrewTestBot added the deprecated license Formula uses a deprecated SPDX license which should be updated label Nov 9, 2020
@samford samford merged commit 501db52 into Homebrew:master Nov 9, 2020
@samford samford deleted the transmission-cli-add-livecheck-strategy branch November 9, 2020 15:53
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 10, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. deprecated license Formula uses a deprecated SPDX license which should be updated livecheck Issues or PRs related to livecheck outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants