Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove livecheck blocks from disabled formulae #64773

Conversation

samford
Copy link
Member

@samford samford commented Nov 14, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

With Homebrew/brew#9112 merged, disabled formulae are now automatically skipped if they don't contain a livecheck block. This PR removes livecheck blocks from some formulae that are disabled and it's appropriate for us to skip checking for new versions.

@samford samford added livecheck Issues or PRs related to livecheck CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Nov 14, 2020
@BrewTestBot BrewTestBot added automerge-skip `brew pr-automerge` will skip this pull request formula disabled Formula disabled and removed automerge-skip `brew pr-automerge` will skip this pull request labels Nov 14, 2020
@samford samford merged commit c16c59f into Homebrew:master Nov 14, 2020
@samford samford deleted the remove-livecheck-blocks-from-disabled-formulae branch November 14, 2020 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula disabled Formula disabled livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants