New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate remaining audit exceptions to homebrew/core #65712
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rylan12
added
the
CI-syntax-only
Change only affects brew syntax, not the install. Only run syntax CI.
label
Nov 26, 2020
BrewTestBot
added
automerge-skip
`brew pr-automerge` will skip this pull request
and removed
CI-syntax-only
Change only affects brew syntax, not the install. Only run syntax CI.
labels
Nov 26, 2020
This was referenced Nov 26, 2020
Rylan12
added
the
CI-syntax-only
Change only affects brew syntax, not the install. Only run syntax CI.
label
Nov 26, 2020
Rylan12
force-pushed
the
migrate-audit-exceptions
branch
from
November 27, 2020 04:24
459639c
to
13c3e70
Compare
BrewTestBot
removed
the
automerge-skip
`brew pr-automerge` will skip this pull request
label
Nov 27, 2020
SMillerDev
previously approved these changes
Nov 27, 2020
Yes, please!
👍🏻 |
Rylan12
force-pushed
the
migrate-audit-exceptions
branch
from
November 27, 2020 16:52
13c3e70
to
4018cc5
Compare
BrewTestBot
removed
the
automerge-skip
`brew pr-automerge` will skip this pull request
label
Nov 27, 2020
Just made a few changes per discussion in Homebrew/brew#9314
|
MikeMcQuaid
approved these changes
Nov 27, 2020
This was referenced Nov 27, 2020
This was referenced Nov 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
automerge-skip
`brew pr-automerge` will skip this pull request
CI-syntax-only
Change only affects brew syntax, not the install. Only run syntax CI.
outdated
PR was locked due to age
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?This PR migrates the remaining audit exceptions to homebrew/core. Corresponding Homebrew/brew PR: Homebrew/brew#9314
A few notes:
VERSIONED_DEPENDENCIES_CONFLICTS_ALLOWLIST
currently has this message above it:# TODO: try to remove these, it's not a good user experience
. We can't have comments in JSON files, so this has been removed. Should I open a new GitHub issue for this?ForDone.VERSIONED_KEG_ONLY_ALLOWLIST
:cairomm@1.14
was added to Homebrew/brew in formula_auditor: add cairomm@1.14 to allowlist brew#9273. However, the homebrew/core PR (cairomm 1.16 cairomm 1.14.2 (newformula) #65531) hasn't been merged yet. If it is merge before this, I will re-addcairomm@1.14
. Until then, though, it cannot be added to the list because that will causebrew audit
to fail. This will be a one-time problem, though. Part of the reason for moving these lists to homebrew/core is so that issues like this won't occur.UNSTABLE_DEVEL_ALLOWLIST
was created to allow for temporary development to occur. Currently, it is empty. We have the option of including an empty JSON file or leaving this file out entirely (although the functionality will remain so it could be added in the future as needed). I opted for adding a blank file because, otherwise, it will probably be very difficult to find next time we need it. If we'd rather leave the file out for now, though, that's fine too.