Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate remaining audit exceptions to homebrew/core #65712

Merged
merged 8 commits into from Nov 27, 2020

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Nov 26, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This PR migrates the remaining audit exceptions to homebrew/core. Corresponding Homebrew/brew PR: Homebrew/brew#9314

A few notes:

  • The VERSIONED_DEPENDENCIES_CONFLICTS_ALLOWLIST currently has this message above it: # TODO: try to remove these, it's not a good user experience. We can't have comments in JSON files, so this has been removed. Should I open a new GitHub issue for this?
  • For VERSIONED_KEG_ONLY_ALLOWLIST: cairomm@1.14 was added to Homebrew/brew in formula_auditor: add cairomm@1.14 to allowlist brew#9273. However, the homebrew/core PR (cairomm 1.16 cairomm 1.14.2 (newformula) #65531) hasn't been merged yet. If it is merge before this, I will re-add cairomm@1.14. Until then, though, it cannot be added to the list because that will cause brew audit to fail. This will be a one-time problem, though. Part of the reason for moving these lists to homebrew/core is so that issues like this won't occur. Done.
  • UNSTABLE_DEVEL_ALLOWLIST was created to allow for temporary development to occur. Currently, it is empty. We have the option of including an empty JSON file or leaving this file out entirely (although the functionality will remain so it could be added in the future as needed). I opted for adding a blank file because, otherwise, it will probably be very difficult to find next time we need it. If we'd rather leave the file out for now, though, that's fine too.
  • These lists are nearly identical to those that existed in Homebrew/brew. The only changes I made were for formulae that have been updated and no longer need to be in the exception list and some minor reordering.
  • Lastly, worth noting that this PR will need to be merged into homebrew/core and linuxbrew/core before the brew PR can be merged (due to failing CI), so this will not wait for the brew PR. Once I get approvals in both PRs, this should be merged.

@Rylan12 Rylan12 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Nov 26, 2020
@BrewTestBot BrewTestBot added automerge-skip `brew pr-automerge` will skip this pull request and removed CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Nov 26, 2020
@Rylan12 Rylan12 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Nov 26, 2020
@BrewTestBot BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Nov 27, 2020
@Rylan12 Rylan12 added the automerge-skip `brew pr-automerge` will skip this pull request label Nov 27, 2020
SMillerDev
SMillerDev previously approved these changes Nov 27, 2020
@MikeMcQuaid
Copy link
Member

  • The VERSIONED_DEPENDENCIES_CONFLICTS_ALLOWLIST currently has this message above it: # TODO: try to remove these, it's not a good user experience. We can't have comments in JSON files, so this has been removed. Should I open a new GitHub issue for this?

Yes, please!

  • I opted for adding a blank file because, otherwise, it will probably be very difficult to find next time we need it.

👍🏻

@BrewTestBot BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Nov 27, 2020
@Rylan12 Rylan12 added the automerge-skip `brew pr-automerge` will skip this pull request label Nov 27, 2020
@Rylan12
Copy link
Member Author

Rylan12 commented Nov 27, 2020

Just made a few changes per discussion in Homebrew/brew#9314

  1. Added versioned gcc formulae to versioned_keg_only_allowlist.json
  2. Added the TSC as a CODEOWNER for provided_by_macos_depends_on_allowlist.json

@Rylan12 Rylan12 merged commit 1c960f2 into Homebrew:master Nov 27, 2020
@Rylan12 Rylan12 deleted the migrate-audit-exceptions branch November 27, 2020 21:51
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 28, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants