Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ktmpl: fix typo in formula (found by codespell) #66914

Closed
wants to merge 1 commit into from
Closed

ktmpl: fix typo in formula (found by codespell) #66914

wants to merge 1 commit into from

Conversation

stweil
Copy link
Contributor

@stweil stweil commented Dec 14, 2020

Signed-off-by: Stefan Weil sw@weilnetz.de

@stweil
ktmpl: fix typo in formula (found by codespell)
1fe901f 
Signed-off-by: Stefan Weil <sw@weilnetz.de>
@BrewTestBot BrewTestBot added the rust Rust use is a significant feature of the PR or issue label Dec 14, 2020
@carlocab
Copy link
Member

carlocab commented Dec 14, 2020 •
edited
Loading

ktmpl has been failing CI because of the test for a few weeks now. If this fixes that I may shoot myself.

This probably should get a full test run?

@stweil
Copy link
Contributor Author

stweil commented Dec 14, 2020

A local brew install --build-from-source ktmpl works, and brew test ktmpl passes. brew audit --strict ktmpl failed to build required software (nokogiri), so I could not run that. Please review.

@stweil
Copy link
Contributor Author

stweil commented Dec 14, 2020

If this fixes that I may shoot myself.

Please don't. 😃

@carlocab
Copy link
Member

No, I think you're fine. The audit failure sounds more like an issue with your local Ruby rather than the formula itself.

Brb, going to find a rope. Just remembered there are no guns here.

@carlocab carlocab mentioned this pull request Dec 14, 2020
Closed
5 tasks
@stweil stweil mentioned this pull request Dec 14, 2020
Closed
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@stweil stweil deleted the typo branch December 15, 2020 16:59
@carlocab
Copy link
Member

Oh, and thanks, @stweil! I forgive you for breaking luajit.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 15, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stweil @carlocab @BrewTestBot @SMillerDev