Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zeromq: add dependency on libsodium #67039

Closed
wants to merge 1 commit into from

Conversation

nightlark
Copy link
Contributor

@nightlark nightlark commented Dec 17, 2020

Using TweetNaCl can result in shutdown errors from libzmq (particularly when used in multithreaded programs), and it is not recommended for "production" use. Using libsodium is the default recommended by the libzmq maintainers as per the discussion in: zeromq/libzmq#2991 (comment)

Also adds the SPDX license LGPL-3.0-or-later: https://github.com/zeromq/libzmq#license

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added the missing license Formula has a missing license which should be added label Dec 17, 2020
@BrewTestBot BrewTestBot added deprecated license Formula uses a deprecated SPDX license which should be updated and removed missing license Formula has a missing license which should be added labels Dec 17, 2020
@nightlark nightlark force-pushed the zeromq-with-libsodium branch 3 times, most recently from d1bb5d1 to 0dd6faf Compare December 17, 2020 03:55
@BrewTestBot BrewTestBot removed the deprecated license Formula uses a deprecated SPDX license which should be updated label Dec 17, 2020
@nightlark
Copy link
Contributor Author

nightlark commented Dec 17, 2020

Oh oops. I'd searched for libzmq and zmq when checking for open PRs. #66238 shows up when looking for zeromq.

I could turn this into a PR that just adds the license info, then the other change could wait until @minrk splits his changes into separate commits?

Using TweetNaCl can result in shutdown errors from libzmq, and it
is not recommended for "production" use. libsodium is the default
recommended by the libzmq maintainers as per the discussion in:
zeromq/libzmq#2991 (comment)
@carlocab
Copy link
Member

There's been no response on that other PR for 10 days. I think you're fine to keep the libsodium dependency change. The other PR can just be rebased onto master if yours gets merged first.

Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nightlark ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 17, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants