Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qjson: move to using Qt5. #6823

Closed
wants to merge 1 commit into from
Closed

qjson: move to using Qt5. #6823

wants to merge 1 commit into from

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Nov 11, 2016 •
edited

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Qt4 is EOL. Also, use GitHub tarball.

@MikeMcQuaid
qjson: move to using Qt5.
feac632 
Qt4 is EOL. Also, use GitHub tarball.
@MikeMcQuaid
Copy link
Member Author

Only master works with Qt5 apparently. Have jumped in on the issue here to see if we can get a release: flavio/qjson#49.

@MikeMcQuaid
Copy link
Member Author

No reply from upstream maintainer so 💀 time.

@MikeMcQuaid MikeMcQuaid deleted the qjson-qt5 branch November 17, 2016 16:37
@MikeMcQuaid
Copy link
Member Author

(also contacted them directly on Twitter)

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilovezfs ilovezfs ilovezfs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MikeMcQuaid @ilovezfs