eject 0.1.12 (new formula)

[edwardloveall]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

[edwardloveall]

I'm aware that this is a pretty weak test. Right now the tool only prints out usage instructions or requires a xib which would be a lot of lines to embed for a test. If you think that's reasonable or there's a better way, let me know and I'll change it.

[MikeMcQuaid]

What's the smallest possible xib that can be created?

[edwardloveall]

Looks like I can create one that's 16 lines long, which doesn't seem that bad:

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<document type="com.apple.InterfaceBuilder3.CocoaTouch.XIB" version="3.0" toolsVersion="11134" systemVersion="15F34" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" colorMatched="YES">
    <dependencies>
        <plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="11106"/>
        <capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
    </dependencies>
    <objects>
        <placeholder placeholderIdentifier="IBFilesOwner" id="-1" userLabel="File's Owner"/>
        <placeholder placeholderIdentifier="IBFirstResponder" id="-2" customClass="UIResponder"/>
        <view contentMode="scaleToFill" id="iN0-l3-epB">
            <rect key="frame" x="0.0" y="0.0" width="375" height="667"/>
            <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
            <color key="backgroundColor" red="1" green="1" blue="1" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
        </view>
    </objects>
</document>

When run through eject, it creates the following output:

// Create Views
let view = UIView()
view.frame = CGRect(x: 0, y: 0, width: 375, height: 667)
view.autoresizingMask = [.flexibleHeight, .flexibleWidth]
view.backgroundColor = UIColor(red: 1, green: 1, blue: 1, alpha: 1)

[edwardloveall]

Ok, I created a better test. Let me know what you think!

[bfontaine]

You can drop the parentheses here.

[bfontaine]

The build failed as well as the audit:

Error: 2 problems in 1 formula
eject:
  * GitHub repository not notable enough (<20 forks, <20 watchers and <50 stars)
  * GitHub repository too new (<30 days old)

[edwardloveall]

Oh, I see it's failing on the repository not being popular enough. I guess I'll do a tab instead. Sorry!

[MikeMcQuaid]

@edwardloveall Leave this open, we might include it anyway.

[edwardloveall]

Sure thing. I can also squash the commits if there's nothing else to change before it's merged. Let me know.

[bfontaine]

Use assert_equal swift, shell_output("#{bin}/eject --file view.xib") instead.

[edwardloveall]

Done

[MikeMcQuaid]

Use EOS.undent here and then you can indent the line below (and all others) two characters more than before file.write

[MikeMcQuaid]

Similarly use EOS.undent here.

[edwardloveall]

Done

[MikeMcQuaid]

Don't need the xib assignment here and use (testpath/"view.xib").write instead of the block

[edwardloveall]

👍

[MikeMcQuaid]

Failing on Yosemite so may need scoped to e.g. Xcode 8: https://bot.brew.sh/job/Homebrew%20Core/11454/version=yosemite/testReport/junit/brew-test-bot/yosemite/install_eject/

[MikeMcQuaid]

Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!