Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grv: deprecate/disable #69633

Merged
merged 1 commit into from
Jan 23, 2021
Merged

grv: deprecate/disable #69633

merged 1 commit into from
Jan 23, 2021

Conversation

carlocab
Copy link
Member

grv has not built for a while, and this causes CI issues with every go
version bump. (e.g. #69337)

This was reported at rgburke/grv#107.

I've set the disable date for one year from the upstream report.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@carlocab
grv: deprecate/disable
cdb88c4 
grv has not built for a while, and this causes CI issues with every go
version bump.

This was reported at rgburke/grv#107.

I've set the disable date for one year from the upstream report.
@carlocab carlocab added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Jan 23, 2021
@BrewTestBot BrewTestBot added deprecated license Formula uses a deprecated SPDX license which should be updated formula disabled Formula disabled go Go use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle labels Jan 23, 2021
@carlocab carlocab mentioned this pull request Jan 23, 2021
Closed
5 tasks
@chenrui333 chenrui333 added the automerge-skip `brew pr-automerge` will skip this pull request label Jan 23, 2021
@carlocab carlocab merged commit 0f44a03 into Homebrew:master Jan 23, 2021
@carlocab carlocab deleted the grv-disable branch January 23, 2021 23:50
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 23, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. deprecated license Formula uses a deprecated SPDX license which should be updated formula disabled Formula disabled go Go use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carlocab @chenrui333 @BrewTestBot