Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parliament 1.3.1 (new formula) #69770

Closed
wants to merge 1 commit into from
Closed

parliament 1.3.1 (new formula) #69770

wants to merge 1 commit into from

Conversation

BastianZim
Copy link
Contributor

parliament 1.3.1 (new formula)

Add formula

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue labels Jan 26, 2021
dtrodrigues
dtrodrigues reviewed Jan 26, 2021
View reviewed changes
Formula/parliament.rb Outdated Show resolved Hide resolved
@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Jan 26, 2021
@alebcay alebcay added the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label Jan 26, 2021
@BastianZim
Copy link
Contributor Author

@dtrodrigues I'm not 100% sure how to rebase this. Is it just running git rebase --interactive origin/master and then selecting the commit at the top?

@dtrodrigues
Copy link
Member

Yeah - you'll want to rebase and then 'pick' the first commit and 'fixup' the other commits so that you keep their contents but lose their commit messages. The sha and location of the head need to be updated as well.

@BastianZim
parliament 1.3.1 (new formula)
577444f 
parliament 1.3.1 (new formula)

Add formula
@BrewTestBot BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jan 26, 2021
@BastianZim
Copy link
Contributor Author

BastianZim commented Jan 26, 2021 •
edited

@dtrodrigues Would you mind having a look again? Everything should be incorporated now. Thanks!

carlocab
carlocab approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @BastianZim.

@BastianZim
Copy link
Contributor Author

Thank you @carlocab!

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@BastianZim BastianZim mentioned this pull request Jan 26, 2021
Open
@BastianZim BastianZim deleted the add-parliament-2 branch January 26, 2021 16:07
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 26, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab approved these changes

@dtrodrigues dtrodrigues Awaiting requested review from dtrodrigues

Assignees
No one assigned
Labels
CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@BastianZim @dtrodrigues @BrewTestBot @carlocab @alebcay