Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python@3.8: use our own tcl-tk #70249

Closed
wants to merge 1 commit into from
Closed

python@3.8: use our own tcl-tk #70249

wants to merge 1 commit into from

Conversation

jamiesnape
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Analog of #67378 and for the same reasons.

@BrewTestBot BrewTestBot added the legacy Relates to a versioned @ formula label Feb 2, 2021
@carlocab
Copy link
Member

carlocab commented Feb 3, 2021

Thanks, @jamiesnape.

Marking this as do not merge for the moment, as #68528 should probably be merged before this one. That's been open for a while and requires a rather long CI run, so I'd rather this PR was rebased to incorporate those changes than vice-versa.

@carlocab
Copy link
Member

carlocab commented Feb 3, 2021

Rebased to incorporate changes from #68528.

@jamiesnape, please double-check that I resolved the merge conflicts correctly. Thanks!

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jamiesnape.

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@jamiesnape jamiesnape deleted the jamiesnape-python@3.8-tcl-tk branch February 3, 2021 13:44
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 6, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
legacy Relates to a versioned @ formula outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants