snap-telemetry 0.19.0 #7198
Closed
snap-telemetry 0.19.0 #7198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nijikon
reviewed
Nov 27, 2016
| system "go", "build", "-o", "snapd", "-ldflags", "-w -X main.gitversion=#{version}" | ||
| bin.install "snapd" | ||
| system "go", "build", "-o", "snapteld", "-ldflags", "-w -X main.gitversion=#{version}" | ||
| sbin.install "snapteld" |
There was a problem hiding this comment.
Why it was changed from snapd to snapteld?
There was a problem hiding this comment.
I think it's fine given the names they use in the tarball.
nijikon
reviewed
Nov 27, 2016
| snaptel = buildpath/"src/github.com/intelsdi-x/snap/cmd/snaptel" | ||
| cd snaptel do | ||
| system "go", "build", "-o", "snaptel", "-ldflags", "-w -X main.gitversion=#{version}" | ||
| bin.install "snaptel" |
There was a problem hiding this comment.
Why it was changed from snapctl to snaptel?
There was a problem hiding this comment.
I think it's fine given the names they use in the tarball.
|
Thanks again for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock! |
|
In case anyone sees this issue and wonder about the binary name change. It's updated due to conflicts with Ubuntu snap project. For more info see: intelsdi-x/snap#1344 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?