-
-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xray: add plist #73393
xray: add plist #73393
Conversation
Please provide a default config file like v2ray. |
It would also be good to bump the revision here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🤖 A scheduled task has triggered a merge. |
|
Needed rebasing to publish the bottle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use the new syntax for plist
s? Example:
Lines 323 to 330 in 7df2ebb
plist_options manual: "php-fpm" | |
service do | |
run [opt_sbin/"php-fpm", "--nodaemonize"] | |
run_type :immediate | |
keep_alive true | |
error_log_path var/"log/php-fpm.log" | |
working_dir var | |
end |
Also, please bump the revision
(either add revision 1
or increment the revision
right after license
) so that users get the updated version of the formula when they do brew upgrade
. Squash your changes with your first commit when you do this.
Thanks!
Seems like this needs Homebrew/brew#11355, and that has to land in a release tag first. |
@carlocab It's merged, could you re-review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience here. Just one question. Feel free to ping me again when you're ready.
Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>
resource("geosite").stage do | ||
pkgshare.install "dlc.dat" => "geosite.dat" | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resource("geosite").stage do | |
pkgshare.install "dlc.dat" => "geosite.dat" | |
end | |
pkgshare.install resource("geosite") => "geosite.dat" |
Does this not work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know that. Let me check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error: An exception occurred within a child process:
TypeError: no implicit conversion of Resource into String
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that's fine. We can keep this one.
Thanks, @xiruizhao. GitHub Actions is suffering a partial outage at the moment, so we'll probably need to re-run CI later when it's back up. |
🤖 A scheduled task has triggered a merge. |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?