-
-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-more-secrets 0.1.0 (new formula) #752
Conversation
Build failure is just because the repository is young. Which it is. But it's already got almost 1,000 stars. Any objections to pulling this in now?
|
@@ -0,0 +1,16 @@ | |||
class NoMoreSecrets < Formula | |||
desc 'Recreates the SETEC ASTRONOMY effect from "Sneakers"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not too happy with the single quotes we have banned almost everywhere else, but oh well …
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably be reversed, so the single quotes are inside the desc
element rather than wrapping it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or just escape it and use double quotes in both places, but escaping is a bit messy in this situation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, the inner quotes aren't even needed. After all it's Sneakers and not sneakers, so the quotes don't convey any additional information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it is rendered in plain text in a terminal, so I can't italicize in this case. (Well, I could in some terminals, but we don't have markup for that, and I'm loath to put raw ANSI terminal-control codes in a description.) I think some typography is called for to indicate that it's a title, and not just a proper noun like a restaurant name. I chose double-quotes as a second-best substitute for italics; this seems to be a common convention when more advanced typesetting isn't available, at least in American English. And I've usually seen it in double quotes, not single quotes.
Happy to switch to escaped double quotes inside double quotes — it started out like this but I flipped it to single quotes on the outside just because it looked ugly and I thought folks would actually prefer the single-quote/double-quote inversion to backslashes. In the Ruby books I've read, that use is touted as one of the motivations for the interchangeability of double and single quotes in Ruby.
One more item for the Prose Style Guide, I guess. ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't suggesting to use italics (and definitely am for sticking with plain text in the description), merely trying to say that the capitalized title sufficiently sticks out from the sentence case that is used in the rest of the description. Of course that's just my subjective feeling and as a non-native speaker it's difficult to judge how this is perceived by others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should rewrite all formulae in Markdown to resolve this issue 😜. Would prefer the single quotes to be inside double quotes, but I'm not overly passionate about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched it to single-quotes-in-double-quotes in 60eb33f, since that seems to be preferred and it still reads fine as both code and brew info no-more-secrets
output.
brew install <formula>
(where<formula>
is the name of the formula you're submitting)?brew audit --strict --online <formula>
(after doingbrew install <formula>
)?Description
Brian Barto's no-more-secrets TTY toy. Recreates the SETEC ASTRONOMY effect from the movie "Sneakers".
(This is basically a
curses
demo. Does not actually support universal decryption of all secret data, at least not in the 0.x release series.)Hat tip to this week's Changelog Weekly mailing list for pointing me at this project.