Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openldap 2.5.4 #76306

Closed
wants to merge 8 commits into from
Closed

openldap 2.5.4 #76306

wants to merge 8 commits into from

Conversation

miccal
Copy link
Member

@miccal miccal commented Apr 30, 2021

Created with brew bump-formula-pr.

@nandahkrishna
Copy link
Member

I think curl, heimdal and lighttpd need revision bumps.

@chenrui333 chenrui333 added the build failure CI fails while building the software label Apr 30, 2021
@chenrui333
Copy link
Member

openldap.c:83:17: error: static declaration of 'ldap_connect' follows non-static declaration
static CURLcode ldap_connect(struct Curl_easy *data, bool *done);
                ^
/usr/local/opt/openldap/include/ldap.h:1554:1: note: previous declaration is here
ldap_connect( LDAP *ld );
^
openldap.c:210:17: error: static declaration of 'ldap_connect' follows non-static declaration
static CURLcode ldap_connect(struct Curl_easy *data, bool *done)
                ^
/usr/local/opt/openldap/include/ldap.h:1554:1: note: previous declaration is here
ldap_connect( LDAP *ld );
^
/bin/sh ../libtool  --tag=CC   --mode=compile clang -DHAVE_CONFIG_H   -I../include -I../lib -I../lib  -DBUILDING_LIBCURL  -DCURL_HIDDEN_SYMBOLS -isystem /usr/local/Cellar/openssl@1.1/1.1.1k/include -isystem /usr/local/Cellar/openssl@1.1/1.1.1k/include -isystem /usr/local/Cellar/libssh2/1.9.0_1/include -isystem /usr/local/Cellar/openssl@1.1/1.1.1k/include -isystem /usr/local/Cellar/rtmpdump/2.4+20151223_1/include -isystem /usr/local/Cellar/libidn2/2.3.0/include -isystem /usr/local/Cellar/nghttp2/1.43.0/include  -fvisibility=hidden -Qunused-arguments -Os -Werror=partial-availability  -c -o libcurl_la-pop3.lo `test -f 'pop3.c' || echo './'`pop3.c
2 errors generated.

@cho-m
Copy link
Member

cho-m commented May 12, 2021

curl upstream issue: curl/curl#7004

May want to see if fix patches cleanly: curl/curl@8bdde6b

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label May 12, 2021
@nandahkrishna
Copy link
Member

nandahkrishna commented May 12, 2021

Thanks @cho-m, the patch applies cleanly.

On ARM:

Error: 3 failed steps!
brew install php
brew install php@7.4
brew test --retry --verbose phpunit

Mojave:

Error: 4 failed steps!
brew install php
brew install php@7.3
brew install php@7.4
brew test --retry --verbose phpunit

All due to dyld: Library not loaded: /opt/homebrew/opt/openldap/lib/libldap-2.4.2.dylib.

@cho-m
Copy link
Member

cho-m commented May 12, 2021

I guess those php formulas need revision bumps too.

@nandahkrishna nandahkrishna added ready to merge PR can be merged once CI is green and removed build failure CI fails while building the software labels May 13, 2021
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@miccal miccal deleted the bump-openldap-2.5.4 branch May 13, 2021 12:59
@derrabus derrabus mentioned this pull request May 14, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants