Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt 6.0.4 #76670

Closed
wants to merge 7 commits into from
Closed

qt 6.0.4 #76670

wants to merge 7 commits into from

Conversation

paperchalice
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed on Mojave. Is that expected?


depends_on "assimp"
depends_on "brotli"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to change this?

-no-feature-brotli

@cho-m
Copy link
Member

cho-m commented May 5, 2021

Mojave node is failing on 10.15 SDK API usage, e.g. charactersByApplyingModifiers

It will probably require a minimum of Xcode with SDK 10.15.

@carlocab
Copy link
Member

carlocab commented May 5, 2021

It will probably require a minimum of Xcode with SDK 10.15.

Mojave should have Xcode 11.4, so that should work with an Xcode dependency. Could gated with if MacOS.version <= :mojave.

@Bo98
Copy link
Member

Bo98 commented May 5, 2021

It will probably require a minimum of Xcode with SDK 10.15.

Would did this change in a bug fix release? Sounds like a bug or something going wrong rather than anything intentional.

@cho-m
Copy link
Member

cho-m commented May 5, 2021

Would did this change in a bug fix release? Sounds like a bug or something going wrong rather than anything intentional.

This PR does remove depends_on xcode: [:build, :test], if that impacts anything.

@Bo98
Copy link
Member

Bo98 commented May 5, 2021

Yes, that would make it switch from the Xcode 10.15 SDK to the CLT 10.14 SDK.

It's also why you suddenly needed a ENV.delete "CPATH" in your test (qmake doesn't like CLT SDKs very much).

@Bo98
Copy link
Member

Bo98 commented May 5, 2021

Arguably, the code should be wrapped in a QT_MACOS_PLATFORM_SDK_EQUAL_OR_ABOVE(__MAC_10_15), but maybe they don't support older SDKs in Qt6 despite there being version checks in some places.

@paperchalice paperchalice deleted the qt branch May 7, 2021 11:24
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants