Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite 3.36.0 #79624

Closed
wants to merge 1 commit into from
Closed

sqlite 3.36.0 #79624

wants to merge 1 commit into from

Conversation

gromgit
Copy link
Member

@gromgit gromgit commented Jun 19, 2021

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Jun 19, 2021
@gromgit
Copy link
Member Author

gromgit commented Jun 20, 2021

Wow! Such error! This is gonna take a while...

Formula 10.14 10.15 11 11-arm64 Ignore? Notes
asuka x Y no bottles (#79624 (comment))
cake (install) x Y no ARM mono bottle (prerequisite)
cargo-watch x x x x (unable to replicate locally)
corral x Y out of memory: : Invalid argument (#79624 (comment))
creduce x Y no bottles (#79624 (comment))
hyperkit x x x #72028 (broken test case, fix unknown)
lean x x x x Y test-bot issue (#79624 (comment))
llvm@7 x Y no bottles (#79624 (comment))
llvm@8 x Y no bottles (#79624 (comment))
llvm@9 x Y no bottles (#79624 (comment))
mathlibtools x x x x Y test-bot issue (#79624 (comment))
monkeysphere x x #77242
opencascade x Y #77715
paket (install) x Y no ARM mono bottle (prerequisite)
ponyc x Y out of memory: : Invalid argument (#79624 (comment))
subversion x #76900, #76964, #76970
swift x Y error: Swift does not support the SDK 'MacOSX10.14.sdk'
wasm-pack x x x Y Upstream issue rustwasm/wasm-pack#907
x86_64-elf-gdb (install) x x x x brew link conflict with i686-elf-binutils

@carlocab
Copy link
Member

carlocab commented Jun 20, 2021

mathlibtools and lean is a test-bot bug. They depend on coreutils, but coreutils was unlinked at some earlier stage.

A number of the Big Sur failures (e.g. asuka, creduce, llvm@{7,8,9}) have no bottles.

opencascade and (I think) swift on Mojave are pre-existing. So are monkeysphere and mytop on ARM/Intel Big Sur.

@carlocab
Copy link
Member

Similar failures on #79585. Any test that failed there too is unlikely to be due to either version bump (i.e. this one or gdbm).

@gromgit
Copy link
Member Author

gromgit commented Jun 20, 2021

Thanks much, @carlocab! Indeed, aside from those you mention, there are at least a couple more (hyperkit and wasm-pack) that are carry-overs from the last version bump (#75515). I'll reformat and annotate the failure list above, so that whoever does the next version bump gets a running start on dealing with expected failures.

gromgit added a commit to gromgit/homebrew-core that referenced this pull request Jun 20, 2021
Addresses test error `Expected /username\ you\ specified/ to match "ListUtil.c: loadable library and perl binaries are mismatched (got handshake key 0xc500080, needed 0xc400080)\n".`

Also remove "make test" per `brew audit` complaint.

In support of Homebrew#79624.
@carlocab
Copy link
Member

carlocab commented Jun 20, 2021

game-music-emu is a bit weird, since we do this:

system "cmake", ".", *std_cmake_args, "-DENABLE_UBSAN=OFF"

It's easy enough to point this to the right dylib by adding the RPATH

MacOS.sdk_path/"usr/lib/clang/12.0.5/lib/darwin/libclang_rt.ubsan_osx_dynamic.dylib"

but this is fragile, as this path changes between Xcode/CLT/macOS version bumps.

x86_64-elf-gdb should also not be a problem given #78811. Edit: Ah, no, that removed a conflict between x86_64-elf-gdb and i386-elf-gdb, but this is a conflict between x86_64-elf-gdb and i686-elf-binutils. Wonder how this never came up before.

@carlocab
Copy link
Member

carlocab commented Jun 20, 2021

Interestingly, even the Catalina and Mojave bottles for game-music-emu have linkage with libclang_rt.ubsan_osx_dynamic.dylib.

❯ otool -L */lib/libgme.dylib
0.6.3_2-bigsur/lib/libgme.dylib:
        @@HOMEBREW_PREFIX@@/opt/game-music-emu/lib/libgme.0.dylib (compatibility version 0.0.0, current version 0.6.3)
        /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
        /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 904.4.0)
        @rpath/libclang_rt.ubsan_osx_dynamic.dylib (compatibility version 0.0.0, current version 0.0.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1292.0.0)
0.6.3_2-catalina/lib/libgme.dylib:
        @@HOMEBREW_PREFIX@@/opt/game-music-emu/lib/libgme.0.dylib (compatibility version 0.0.0, current version 0.6.3)
        /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
        /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 902.1.0)
        @rpath/libclang_rt.ubsan_osx_dynamic.dylib (compatibility version 0.0.0, current version 0.0.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1281.100.1)
0.6.3_2-mojave/lib/libgme.dylib:
        @@HOMEBREW_PREFIX@@/opt/game-music-emu/lib/libgme.0.dylib (compatibility version 0.0.0, current version 0.6.3)
        /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
        /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.4)
        @rpath/libclang_rt.ubsan_osx_dynamic.dylib (compatibility version 0.0.0, current version 0.0.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.250.1)

It's only on Big Sur that the linker can't find the library, though. This might be why:

❯ for lib in */lib/libgme.dylib; do echo "$(printf '=%.0s' {1..30})\n$lib\n$(printf '=%.0s' {1..30})" && otool -l $lib | rg -A2 LC_RPATH; done
==============================
0.6.3_2-bigsur/lib/libgme.dylib
==============================
          cmd LC_RPATH
      cmdsize 32
         path @executable_path (offset 12)
--
          cmd LC_RPATH
      cmdsize 128
         path /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/12.0.0/lib/darwin (offset 12)
==============================
0.6.3_2-catalina/lib/libgme.dylib
==============================
          cmd LC_RPATH
      cmdsize 32
         path @executable_path (offset 12)
--
          cmd LC_RPATH
      cmdsize 128
         path /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/12.0.0/lib/darwin (offset 12)
==============================
0.6.3_2-mojave/lib/libgme.dylib
==============================
          cmd LC_RPATH
      cmdsize 32
         path @executable_path (offset 12)
--
          cmd LC_RPATH
      cmdsize 128
         path /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/11.0.0/lib/darwin (offset 12)

The LC_RPATH entries are valid on Mojave and Catalina, but not on Big Sur (but they were correct at build-time).

It seems these also only work if you have Xcode installed.

gromgit added a commit to gromgit/homebrew-core that referenced this pull request Jun 20, 2021
Fixes test error `DBI.c: loadable library and perl binaries are mismatched (got handshake key 0xc500080, needed 0xc400080)`

In support of Homebrew#79624.
BrewTestBot pushed a commit that referenced this pull request Jun 20, 2021
Addresses test error `Expected /username\ you\ specified/ to match "ListUtil.c: loadable library and perl binaries are mismatched (got handshake key 0xc500080, needed 0xc400080)\n".`

Also remove "make test" per `brew audit` complaint.

In support of #79624.

Closes #79674.

Signed-off-by: Nanda H Krishna <me@nandahkrishna.com>
Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
@gromgit gromgit mentioned this pull request Jun 20, 2021
6 tasks
@gromgit
Copy link
Member Author

gromgit commented Jun 20, 2021

OK, mytop, innotop and game-music-emu all failed local testing (Intel Big Sur) from bottles, but I've rev-bumped all three and they pass locally now.

I suspect ponyc also needs a rebuild, but I ran out of space locally. Will fix that later today (0230J now).

BrewTestBot pushed a commit that referenced this pull request Jun 20, 2021
Fixes test error `DBI.c: loadable library and perl binaries are mismatched (got handshake key 0xc500080, needed 0xc400080)`

In support of #79624.

Closes #79678.

Signed-off-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
@carlocab carlocab mentioned this pull request Jun 21, 2021
gromgit added a commit to gromgit/homebrew-core that referenced this pull request Jun 21, 2021
Fixes test error:
```
dyld: Library not loaded: @rpath/libclang_rt.ubsan_osx_dynamic.dylib
  Referenced from: /usr/local/opt/game-music-emu/lib/libgme.0.dylib
  Reason: image not found
```
In support of Homebrew#79624.
@gromgit
Copy link
Member Author

gromgit commented Jun 21, 2021

ponyc bottle fails locally on Intel Big Sur, despite #76829:

$ brew info ponyc
ponyc: stable 0.41.0 (bottled)
Object-oriented, actor-model, capabilities-secure programming language
https://www.ponylang.org/
/usr/local/Cellar/ponyc/0.41.0 (193 files, 28.4MB) *
  Poured from bottle on 2021-06-21 at 16:05:46
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/ponyc.rb
License: BSD-2-Clause
==> Dependencies
Build: cmake ✔
==> Analytics
install: 69 (30 days), 405 (90 days), 1,631 (365 days)
install-on-request: 61 (30 days), 377 (90 days), 1,480 (365 days)
build-error: 0 (30 days)

$ ponyc
out of memory: : Invalid argument
Abort trap: 6

Rebuilding from source yields the same crash.

Also, @chenrui333 reported a 0.41.1 build failure with exactly the same symptoms: ponylang/ponyc#3764. As suggested there, I tried wiping my existing CLT and manually reinstalling the latest CLT download (12.5), but both bottle and source builds continue failing in the same way.

I've confirmed that neither ponyc nor corral (which is just a ponyc dependency manager, and in fact runs the same test case) use SQLite in any way, so I propose ignoring those failures for the purpose of this PR.

@cho-m
Copy link
Member

cho-m commented Jun 22, 2021

Looks like homepage update (#79685) caused merge conflict.

There is an open issue for dealing with some linkage conflicts in cross binutils (maybe v2.36.1) #78849 (comment), (which should also be expanded to deal with binutils-gdb-based formulae). Either setting --libdir or deleting files are options.

@carlocab
Copy link
Member

Oops. Let me rebase this.

@carlocab
Copy link
Member

ARM

Error: 9 failed steps!
brew install --only-dependencies cake
brew install cake
brew test --retry --verbose cargo-watch
brew test --retry --verbose lean
brew test --retry --verbose mathlibtools
brew test --retry --verbose monkeysphere
brew install --only-dependencies paket
brew install paket
brew install --only-dependencies --include-test x86_64-elf-gdb

Big Sur

Error: 14 failed steps!
brew test --retry --verbose asuka
brew test --retry --verbose cargo-watch
brew test --retry --verbose corral
brew test --retry --verbose creduce
brew test --retry --verbose hyperkit
brew test --retry --verbose lean
brew test --retry --verbose llvm@7
brew test --retry --verbose llvm@8
brew test --retry --verbose llvm@9
brew test --retry --verbose mathlibtools
brew test --retry --verbose monkeysphere
brew test --retry --verbose ponyc
brew test --retry --verbose wasm-pack
brew install --only-dependencies --include-test x86_64-elf-gdb

Catalina

Error: 7 failed steps!
brew test --retry --verbose cargo-watch
brew test --retry --verbose hyperkit
brew test --retry --verbose lean
brew test --retry --verbose mathlibtools
brew test --retry --verbose subversion
brew test --retry --verbose wasm-pack
brew install --only-dependencies --include-test x86_64-elf-gdb

Mojave

Error: 8 failed steps!
brew test --retry --verbose cargo-watch
brew test --retry --verbose hyperkit
brew test --retry --verbose lean
brew test --retry --verbose mathlibtools
brew test --retry --verbose opencascade
brew test --retry --verbose swift
brew test --retry --verbose wasm-pack
brew install --only-dependencies --include-test x86_64-elf-gdb

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @gromgit.

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Jul 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants