libgit2-glib: m1-support add in rpath to build on Apple Silicon #80314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrewTestBot
added
deprecated license
nandahkrishna
added
the
CI-force-arm
|
Let's wait for feedback from upstream on your patch. |
carlocab
reviewed
Jul 1, 2021
| url "https://gitlab.gnome.org/GNOME/libgit2-glib/-/commit/e5e61a523508851daa6e54333c2747b7807496fb.diff" | ||
| sha256 "6b311f239a872b102a018b1ed14a72fdad18ca4e2c47de3c2b6b2e9e9b66a69d" | ||
| end | ||
|
|
||
| def install | ||
| mkdir "build" do |
There was a problem hiding this comment.
I also wonder if we can do without the patch by doing
ENV.append "LDFLAGS", "-Wl,-rpath,#{rpath}"Though I do know meson is a bit weird about rpath LDFLAGS.
There was a problem hiding this comment.
I’ll try that
I know meson was pretty interesting to figure out
There was a problem hiding this comment.
ok that worked, lemme push with that instead it seems preferable.
There was a problem hiding this comment.
@carlocab changed to this method
|
Linking upstream here: https://gitlab.gnome.org/GNOME/libgit2-glib/-/merge_requests/29 |
This was opened upstream as https://gitlab.gnome.org/GNOME/libgit2-glib/-/merge_requests/29 to always pass rpath in meson but that might not be correct
areese
force-pushed
the
m1-support/libgit2-glib
branch
from
2bc3b90
to
5e77f0b
Compare
carlocab
approved these changes
Jul 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?