Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apache-arrow: use ENV.runtime_cpu_detection #80501

Closed
wants to merge 1 commit into from

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Jul 3, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Also, add a utf8proc dependency. The build vendors its own otherwise.

Closes #76537


Needs Homebrew/brew#11608 to land in a brew release before merging.

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 3, 2021
Also, add a `utf8proc` dependency. The build vendors its own otherwise.

Closes Homebrew#76537.
@carlocab
Copy link
Member Author

carlocab commented Jul 5, 2021

ENV.runtime_cpu_detection is in https://github.com/Homebrew/brew/releases/tag/3.2.1.

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@carlocab carlocab deleted the apache-arrow branch July 5, 2021 17:38
depends_on "zstd"

def install
# https://github.com/Homebrew/homebrew-core/issues/76537
ENV.runtime_cpu_detection if Hardware::CPU.intel?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlocab all ENV.runtime_cpu_detection calls will be gates by an if Hardware::CPU.intel?, right? What happens if you call it on ARM, do things break? I almost wonder if it just makes more sense to make it a no-op on ARM so it doesn't need the if statements

Copy link
Member Author

@carlocab carlocab Jul 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily -- I think it should also be safe (and desirable) to use unconditionally for formulae like openblas. I just don't know of a good way to actually inspect the binary objects to check that it probably does the right thing on ARM.

@github-actions github-actions bot added the outdated PR was locked due to age label Aug 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apache-arrow segfaults on intel
3 participants