Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kepubify 4.0.0 #80516

Closed
wants to merge 1 commit into from
Closed

kepubify 4.0.0 #80516

wants to merge 1 commit into from

Conversation

chenrui333
Copy link
Member

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` go Go use is a significant feature of the PR or issue labels Jul 3, 2021
@chenrui333
Copy link
Member Author

Error: An exception occurred within a child process:
Errno::ENOENT: No such file or directory - kepub/test.epub

@chenrui333 chenrui333 mentioned this pull request Jul 3, 2021
Merged
7 tasks
@chenrui333 chenrui333 marked this pull request as draft July 3, 2021 22:09
@chenrui333
Copy link
Member Author

test.epub was removed in the upstream repo and we need a dedicated test.epub to test out the formula change. All in all, this test.epub in the fixtures would be a good thing for testing out all the formulae.

@chenrui333 chenrui333 closed this Jul 3, 2021
@pgaskin
Copy link

pgaskin commented Jul 4, 2021

Some notes about kepubify v4:

  • Please add -tags zip117 to the build arguments to keep the performance like the release builds.
  • Go 1.16 is now the minimum Go version.

@chenrui333 chenrui333 marked this pull request as ready for review July 13, 2021 00:34
@chenrui333
Copy link
Member Author

Thanks @EricFromCanada! :)

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Jul 13, 2021
SMillerDev
SMillerDev reviewed Jul 13, 2021
View reviewed changes
Formula/kepubify.rb
Comment on lines 27 to 30
system "go", "build", "-o", bin/p,
"-ldflags", "-s -w -X main.version=#{version}",
"-tags", "zip117",
"./cmd/#{p}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
system "go", "build", "-o", bin/p,
"-ldflags", "-s -w -X main.version=#{version}",
"-tags", "zip117",
"./cmd/#{p}"
system "go", "build",
"-tags", "zip117",
*std_go_args(ldflags: "-s -w -X main.version=#{version}"),
"-o", bin/p,
"./cmd/#{p}"

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Aug 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
@chenrui333 chenrui333 deleted the bump-kepubify-4.0.0 branch December 18, 2022 05:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` go Go use is a significant feature of the PR or issue outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chenrui333 @pgaskin @BrewTestBot @SMillerDev @EricFromCanada