Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*-binutils: add livecheck #82634

Merged
merged 3 commits into from
Aug 4, 2021

Conversation

samford
Copy link
Member

@samford samford commented Aug 4, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Today's 3.2.6 release of brew includes the new formula/cask livecheck block DSL methods (see Homebrew/brew#11743), so now we can start using them in livecheck blocks.

The main purpose of this feature is to allow formulae/casks to use the same check as another, so we can easily sync checks for formulae/casks that use the same stable/url file. Up until now, we've had to duplicate livecheck blocks and manually update them when the canonical livecheck block changes (e.g., sqlite and related formulae). With this, we can simply update the canonical livecheck block and others that reference are automatically updated.

As mentioned in the related documentation, these methods should only reference a formula/cask in the same tap, as they will error when a tap isn't already tapped.

One thing that I'll need to update the documentation to mention is that this DSL should only be used when one formula/cask is canonical among those with a duplicate stable/url. If the formulae/casks are all of equal stature (e.g., the beats formulae), this feature shouldn't be used.


With this in mind, this PR updates formulae that have the same stable URL as binutils to use formula "binutils", so these checks are synced.

I've identified the other sets of formulae that can use formula and I'll be creating follow-up PRs for those.

@samford samford added livecheck Issues or PRs related to livecheck CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Aug 4, 2021
@samford samford changed the title Binutils add livecheck references *-binutils: add livecheck Aug 4, 2021
@samford samford merged commit 23f4adf into Homebrew:master Aug 4, 2021
@samford samford deleted the binutils-add-livecheck-references branch August 4, 2021 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant