Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newrelic-infra-agent 1.20.0 (new formula) #82746

Closed
wants to merge 13 commits into from
Closed

newrelic-infra-agent 1.20.0 (new formula) #82746

wants to merge 13 commits into from

Conversation

brushknight
Copy link
Contributor

@brushknight brushknight commented Aug 5, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

For now we use not final version of our code (pre-releases) in order to modify our code. Once we have everything ✅ on the pipeline, we will make a final release and change link & shasum for the tar.gz.

@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Aug 5, 2021
@chenrui333 chenrui333 added the build failure CI fails while building the software label Aug 6, 2021
Formula/newrelic-infra-agent.rb Outdated Show resolved Hide resolved
Formula/newrelic-infra-agent.rb Outdated Show resolved Hide resolved
@carlocab
Copy link
Member

carlocab commented Aug 7, 2021

Please do brew audit --strict --fix newrelic-infra-agent to fix the CI errors.

Also, please don't mark steps in the PR template as done if you did not do them.

@carlocab carlocab added the CI-force-linux [DEPRECATED] Don't pass --skip-unbottled-linux to brew test-bot. label Aug 9, 2021
Formula/newrelic-infra-agent.rb Outdated Show resolved Hide resolved
Formula/newrelic-infra-agent.rb Outdated Show resolved Hide resolved
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Aug 9, 2021
Formula/newrelic-infra-agent.rb Outdated Show resolved Hide resolved
Formula/newrelic-infra-agent.rb Show resolved Hide resolved
Formula/newrelic-infra-agent.rb Outdated Show resolved Hide resolved
Formula/newrelic-infra-agent.rb Outdated Show resolved Hide resolved
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @brushknight. Just one small comment, and I think this can be merged when you mark 1.20 as your latest release on GitHub.

Formula/newrelic-infra-agent.rb Show resolved Hide resolved
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Sep 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build failure CI fails while building the software CI-force-linux [DEPRECATED] Don't pass --skip-unbottled-linux to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants