-
-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duck 7.10.1 #83146
duck 7.10.1 #83146
Conversation
Hi @dkocher, do you mind if I close this and combine it with the PR I have open here: #83110?. In addition to fixing the build on Linux, we will also have to fix some issues on Intel macOS with native binaries and disable building on ARM. One question which you can answer here or in that other PR: do you know where |
@danielnachun I would prefer if we can get this update through first and then handle the new builds for Linux in a separate PR. I can amend this PR to disable builds on
|
I'm totally fine with doing it this way too. I'll just rebase the other PR when this one is merged, as the only thing blocking it right are the audit issues on macOS.
I'm not sure where this is formally written up, but all that adding
Just to be clear, is Maven downloading those files as pre-built artifacts from somewhere? We try whenever possible to avoid doing this so that we won't have compatibility issues etc. Is there a way for us to force Maven to build those from source as well? Alternatively, we could make formulae for them and copy files/symlink into the directories, though that would be a more involved process. |
All dependency management is handled by Maven and we have several an awful long list of dependencies (usually |
What to about the |
I should have clarified here that we prefer to build native artifacts (MachO dylibs and executables) in CI. Java
The audit failure for |
I ended up adding the version bump to my PR because it was simpler to do it all at once. Don't be too alarmed by all the changes in the formula - the resources blocks will be converted to formulae soon, and once we figure out how to tweak the build.xml for Linux as I mentioned over in the Cyberduck Trac, the formula will only be slightly more complex than before. I figured we'd rather get the updated version of Cyberduck to users (and make it available on Linux), even if the formula is a little complicated right now. |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?