Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datree 0.7.1 (new formula) #83693

Closed
wants to merge 2 commits into from
Closed

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

relates to datreeio/datree#115

@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Aug 21, 2021
dawidd6
dawidd6 previously approved these changes Aug 21, 2021
@carlocab carlocab added the CI-force-linux [DEPRECATED] Don't pass --skip-unbottled-linux to brew test-bot. label Aug 21, 2021
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Aug 21, 2021
update default head branch

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
Copy link
Member Author

@dimabru, you might want to update the default branch on datree side?

datree:
  * HEAD: Use `branch: "staging"` to specify the default branch

@chenrui333 chenrui333 added the audit failure CI fails while auditing the software label Aug 22, 2021
@chenrui333
Copy link
Member Author

I am gonna temporarily switch back to staging branch (as it is the listed default branch).

@romanlab
Copy link

@chenrui333 You're absolutely right, our default branch is staging.

But we use staging because we want all pull requests to go automatically to the staging branch, so we can verify the version on our staging environment before we promote it to production.

All stable, production level releases are on our main branch and therefore Homebrew should also point to the main branch to make sure it always references a stable version

@SMillerDev
Copy link
Member

All stable, production level releases are on our main branch and therefore Homebrew should also point to the main branch to make sure it always references a stable version

That's not what the head block is for though. head allows users to do a build from a recent git checkout (to validate patches for example). For the stable version we just use the tagged downloads.

@BrewTestBot
Copy link
Member

:shipit: @SMillerDev has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Sep 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2021
@chenrui333 chenrui333 deleted the datree branch December 18, 2022 05:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
audit failure CI fails while auditing the software CI-force-linux [DEPRECATED] Don't pass --skip-unbottled-linux to brew test-bot. go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants