transcrypt 1.0.1 #8398
Closed
transcrypt 1.0.1 #8398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistydemeo
previously requested changes
Jan 3, 2017
| @@ -15,17 +17,18 @@ def install | |||
| end | |||
|
|
|||
| test do | |||
| system "git", "init" | |||
| git = Formula["git"].opt_bin | |||
| system git, "init" | |||
There was a problem hiding this comment.
This is the bin directory, not the executable, right?
ilovezfs
force-pushed
the
transcrypt-1.0.0
branch
2 times, most recently
from
6bdb04e
to
a2db976
Compare
|
@mistydemeo problem turns out to be the old |
|
Reported here: elasticdog/transcrypt#34. |
ilovezfs
force-pushed
the
transcrypt-1.0.0
branch
from
a2db976
to
eec1b03
Compare
ilovezfs
dismissed
mistydemeo’s stale review
Thanks for catching that. I've removed line in any case since git was actually unrelated.
ilovezfs
force-pushed
the
transcrypt-1.0.0
branch
from
eec1b03
to
0f30bb8
Compare
ilovezfs
force-pushed
the
transcrypt-1.0.0
branch
from
0f30bb8
to
117d868
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created with
brew bump-formula-pr.