Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform-rover: 0.2.2 (new formula) #86711

Closed

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core nodejs Node or npm use is a significant feature of the PR or issue labels Oct 6, 2021
class TerraformRover < Formula
desc "Terraform Visualizer"
homepage "https://github.com/im2nguyen/rover"
url "https://github.com/im2nguyen/rover/archive/refs/tags/v0.2.2.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can just use the shorter one, same artifact.

Suggested change
url "https://github.com/im2nguyen/rover/archive/refs/tags/v0.2.2.tar.gz"
url "https://github.com/im2nguyen/rover/archive/v0.2.2.tar.gz"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what you get when you copy the link in the release page. We should keep that.

chenrui333
chenrui333 previously approved these changes Oct 7, 2021
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chenrui333
Copy link
Member

==> /opt/homebrew/Cellar/terraform-rover/0.2.2/bin/terraform-rover -standalone
2021/10/06 08:09:37 Starting Rover...
2021/10/06 08:09:37 Initializing Terraform...
2021/10/06 08:09:37 Unable to parse Plan: Unable to initialize Terraform Plan: fork/exec /usr/local/bin/terraform: no such file or directory
Error: terraform-rover: failed
An exception occurred within a child process:
  BuildError: Failed executing: /opt/homebrew/Cellar/terraform-rover/0.2.2/bin/terraform-rover -standalone
/opt/homebrew/Library/Homebrew/formula.rb:2297:in `block in system'
Error: test failed

@chenrui333 chenrui333 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. test failure CI fails while running the test-do block labels Oct 7, 2021
@SMillerDev
Copy link
Member Author

Test is fixed ✅

@chenrui333
Copy link
Member

🚀 💯

@BrewTestBot
Copy link
Member

:shipit: @chenrui333 has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Nov 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core nodejs Node or npm use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants