Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isl: switch to https://libisl.sourceforge.io/ for homepage/tarball download #86896

Merged
merged 1 commit into from Oct 8, 2021

Conversation

timoha
Copy link
Contributor

@timoha timoha commented Oct 8, 2021

isl.gforge.inria.fr has been shutdown: https://giters.com/coq/opam-coq-archive/issues/1298?amp=1

@Bo98
Copy link
Member

Bo98 commented Oct 8, 2021

Isn't the official source https://libisl.sourceforge.io/?

@timoha
Copy link
Contributor Author

timoha commented Oct 8, 2021

Isn't the official source https://libisl.sourceforge.io/?

Was not aware of it, I'm happy to update.

@timoha timoha changed the title isl: switch to slackware mirror for download of tarball isl: switch to https://libisl.sourceforge.io/ for homepage/tarball download Oct 8, 2021
@carlocab carlocab added CI-no-bottles Merge without publishing bottles CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. labels Oct 8, 2021
@timoha
Copy link
Contributor Author

timoha commented Oct 8, 2021

Isn't the official source https://libisl.sourceforge.io/?

Was not aware of it, I'm happy to update.

Actually it's still a discussion whether that's an official page: https://groups.google.com/g/isl-development/c/JGaMo2VUu_8

@FiloSottile
Copy link
Sponsor Contributor

It's official, as that is the software author (or at least that's their name). What is being discussed if whether the right link should be the static site hosting or https://downloads.sourceforge.net/project/libisl/isl-0.22.tar.xz. I wonder if SourceForge allows hosting binary releases on the static site.

@timoha
Copy link
Contributor Author

timoha commented Oct 8, 2021

I wonder if SourceForge allows hosting binary releases on the static site.

Seems like they do given that it's possible to download them from https://libisl.sourceforge.io/ (https://libisl.sourceforge.io/isl-0.24.tar.xz).
@FiloSottile mind commenting on https://groups.google.com/g/isl-development/c/JGaMo2VUu_8 if you have preferences of where they should be hosted? I don't have a strong opinion as long as binaries stay there over time.

@FiloSottile
Copy link
Sponsor Contributor

I wonder if SourceForge allows hosting binary releases on the static site.

Seems like they do given that it's possible to download them from https://libisl.sourceforge.io/ (https://libisl.sourceforge.io/isl-0.24.tar.xz). @FiloSottile mind commenting on https://groups.google.com/g/isl-development/c/JGaMo2VUu_8 if you have preferences of where they should be hosted? I don't have a strong opinion as long as binaries stay there over time.

It's clearly technically possible. I was speculating if it might be a ToS violation, making the download links more stable.

https://sourceforge.net/p/forge/documentation/Project%20Web%20Services/ says "Host static HTML content about your project" but is silent about hosting releases, so it might be fine or not, hard to tell.

I don't have a strong opinion either, so I think I will not badger their mailing list.

@Bo98
Copy link
Member

Bo98 commented Oct 8, 2021

As long as it works and doesn't break I don't really have a strong preference either.

Even where future releases go doesn't really matter as long as the old tarballs don't disappear suddenly.

@carlocab
Copy link
Member

carlocab commented Oct 8, 2021

We have a bunch of other formula (e.g isl@0.18) that have tarballs hosted on gforge that could use updating.

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timoha!

By the way, I noticed your PR branch is also called master. It's not a problem here, since the new source tarball is identical to the old one, but for future PRs that require new bottles to be built, please use a PR branch with a different name. (Querying workflow runs for PRs whose branches are named master is broken at the moment, and that makes it impossible for @BrewTestBot to merge PRs along with their bottle commit.)

@carlocab carlocab merged commit fd3dd90 into Homebrew:master Oct 8, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants