Add back the old imagemagick under the name imagemagick@6 #8756

crazymykl · 2017-01-12T05:50:12Z

This is necessary since rmagick does not work with ImageMagick 7.0.x.

Apologies if I'm not following protocol 100%, it was not super clear how new versions of existing formulae should be formatted.

I bought back the formula for the last 6.9.x ImageMagick nearly verbatim, only changing the class name.

ilovezfs · 2017-01-12T06:14:51Z

I do not think sufficient need for this formula has been demonstrated, especially given that there are no dependents in Homebrew itself that need it. The formula will be broken in terms of the ability of build systems to detect it via pkg-config unless it's made keg only or is marked as conflicting with the main imagemagick formula, which will then interfere with the installation of formulae that depend on imagemagick. My recommendation is that you host this in your own tap for the time being.

zmwangx · 2017-01-12T06:28:19Z

My recommendation is that you host this in your own tap for the time being.

The problem with that, in the case of IM, is that it is updated frequently, and whenever an update is issued the old tarball is removed from the server. That's why we brew mirror the tarballs.

But indeed, a formula like this wouldn't work very well. The best compromise is to mark it as keg only, and deal with the hassle of having to specify the opt paths (PATH, LDFLAGS, CPPFLAGS, PKG_CONFIG_PATH) where necessary (which isn't always possible in obscure/hand-crafted build systems), or force link it if you don't need any revdeps.

At the very least it comes down to

I do not think sufficient need for this formula has been demonstrated.

ilovezfs · 2017-01-12T06:29:45Z

The problem with that, in the case of IM, is that it is updated frequently, and whenever an update is issued the old tarball is removed from the server.

Perhaps "someone" should convince upstream to knock that behavior off.

zmwangx · 2017-01-12T06:31:09Z

Perhaps "someone" should convince upstream to knock that behavior off.

That "someone" might need to foot the bill (which might be negligible; I've no idea).

ilovezfs · 2017-01-12T06:35:42Z

Is there something deficient about the _orig tarballs on all Debian mirrors? https://mirrors.ocf.berkeley.edu/debian/pool/main/i/imagemagick/

zmwangx · 2017-01-12T06:41:31Z

Not sure whether dfsg stripping causes problems, I assume not. Two issues:

Only a handful of versions are available, most are skipped;
Debian removes old tarballs on a regular basis, too.

ilovezfs · 2017-01-12T06:44:19Z

Only a handful of versions are available, most are skipped;

Is there some benefit the plethora of updates is providing?

Debian removes old tarballs on a regular basis, too.

I guess this is one of the reasons brew update and the Internet exist.

zmwangx · 2017-01-12T06:47:09Z

Is there some benefit the plethora of updates is providing?

Probably not until you have a CVE.

I guess this is one of the reasons brew update and the Internet exist.

Well, we're talking about user-hosted taps here... Not really our problem, but still.

ilovezfs · 2017-01-12T06:47:43Z

User-hosted taps get updated by brew update.

zmwangx · 2017-01-12T06:48:10Z

It depends on said user updating the formula diligently :)

ilovezfs · 2017-01-12T06:48:38Z

It depends on said user updating the formula diligently

Indeed.

crazymykl · 2017-01-12T13:27:31Z

Again, the rmagick gem, by far the most common reason I have seen ImageMagick installed on macOS, does not build with major version 7. It is unlikely that a version that builds against both 6 and 7 will be forthcoming.,

rmagick has almost 8 million downloads.

ilovezfs · 2017-01-12T13:28:50Z

perhaps we've just given them a reason to add support for 7

crazymykl · 2017-01-12T13:32:01Z

There's also the question of deployment. A lot of apps are ultimately hosted on OSes which won't have a package for ImageMagick@7 for year, or possibly ever (e. g. CentOS).

Flipping the question: what exists that only builds against ImageMagick@7? Maybe 7 should be made keg-only until it is better supported in the wild than version 6.

ilovezfs · 2017-01-12T13:33:29Z

It handles all of the Homebrew dependents. There's no reason to make it keg_only.

zmwangx · 2017-01-12T13:33:35Z

by far the most common reason I have seen ImageMagick installed on macOS

Experience varies, but I'm pretty sure IM on macOS is more often used as standalone tools. Most of those 8 million downloads could well be on Linux web servers, and I'm pretty sure PHP bindings for IM are more prevalent than the Ruby binding on servers.

what exists that only builds against ImageMagick@7?

Homebrew ships cutting edge software. That's the nature of the project.

crazymykl · 2017-01-12T20:09:08Z

I have made a tap, for whoever finds this after googling rmagick homebrew imagemagick 7.

brew install crazymykl/homebrew-custom/imagemagick@6

jacquerie · 2017-01-14T20:08:10Z

Thanks, @crazymykl! I'm using your tap because Wand 0.4.4 appears to support only ImageMagick@6. With ImageMagick@7 I was getting:

ImportError: MagickWand shared library not found.
You probably had not installed ImageMagick library.
Try to install:
  brew install freetype imagemagick

(typing this for the benefit of people searching for the error above).

MikeMcQuaid · 2017-01-16T08:56:37Z

I talked with @ilovezfs and my understanding of the conversation was that we (or at least I) am happy to accept this as long as it's keg-only.

crazymykl · 2017-01-16T15:46:44Z

Formula/imagemagick.rb

@@ -130,6 +130,9 @@ def install

  def caveats
    s = <<-EOS.undent
+      rmagick 2.x does not work with ImageMagick 7, and some invokations of


Not 100% thrilled with the verbiage here.

crazymykl · 2017-01-16T19:48:41Z

Updated. Let me know if there's more to do.

MikeMcQuaid · 2017-01-16T21:05:16Z

Formula/imagemagick.rb

-    s = <<-EOS.undent
+    base = <<-EOS.undent
+      rmagick 2.x does not work with ImageMagick 7, and some invocations of
+      `convert` may have changed syntax.


Let's omit this; there's more than just rmagick and this isn't in keeping with other formulae updates.

MikeMcQuaid · 2017-01-16T21:05:41Z

Formula/imagemagick@6.rb

+    sha256 "9258c4fc88187040a23e8c62e451ef725eb504b721181eba4e6dda382884bf8e" => :sierra
+    sha256 "6bb941944b07a17da426a1fae986ef8b13ba091dd52728e2ed59adb19d5fcce0" => :el_capitan
+    sha256 "7246f8e60983e429ee088e8a3d2f2b3fb780c868cc5f5d3effff4146ddafe12e" => :yosemite
+  end


Remove the bottle block, it'll get re-added when we pull.

MikeMcQuaid · 2017-01-16T21:07:02Z

Formula/imagemagick@6.rb

+        export PERL5LIB="#{HOMEBREW_PREFIX}/lib/perl5/site_perl":$PERL5LIB
+    EOS
+    s if build.with? "perl"
+  end


Probably just worth removing these caveats (or adjusting them to point to opt_lib )

MikeMcQuaid · 2017-01-16T21:07:43Z

Formula/imagemagick@6.rb

+  depends_on "libtiff" => :recommended
+  depends_on "freetype" => :recommended
+
+  depends_on :x11 => :optional


Let's remove this option.

crazymykl · 2017-01-16T22:36:16Z

I did the thing.

MikeMcQuaid · 2017-01-17T10:18:53Z

Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

MikeMcQuaid · 2017-01-17T10:31:56Z

@crazymykl You may want to now remove your tap and/or add the according tap_migrations.json line.

ilovezfs added the do not merge label Jan 12, 2017

ilovezfs added legacy Relates to a versioned @ formula new formula PR adds a new formula to Homebrew/homebrew-core labels Jan 12, 2017

ilovezfs mentioned this pull request Jan 12, 2017

Upgrade: ImageMagick 7.0.x-y #1828

Closed

22 tasks

crazymykl closed this Jan 12, 2017

bjarthur mentioned this pull request Jan 14, 2017

homebrew imagemagick updated to 7.0.4 JuliaIO/ImageMagick.jl#57

Closed

ilovezfs mentioned this pull request Jan 16, 2017

Process for imagemagick@6? #8954

Closed

MikeMcQuaid reopened this Jan 16, 2017

crazymykl force-pushed the version-imagemagick branch from b7863cf to fa92b17 Compare January 16, 2017 15:42

crazymykl commented Jan 16, 2017

View reviewed changes

crazymykl force-pushed the version-imagemagick branch from fa92b17 to 1497f7d Compare January 16, 2017 15:52

crazymykl force-pushed the version-imagemagick branch 2 times, most recently from d4b08be to 3bfd951 Compare January 16, 2017 16:38

MikeMcQuaid requested changes Jan 16, 2017

View reviewed changes

Add back the old imagemagick under the name imagemagick@6

6f48350

crazymykl force-pushed the version-imagemagick branch from 3bfd951 to 6f48350 Compare January 16, 2017 21:41

MikeMcQuaid approved these changes Jan 17, 2017

View reviewed changes

MikeMcQuaid closed this in b62c3d2 Jan 17, 2017

ledermann mentioned this pull request Jan 17, 2017

support for ImageMagick 7.0.x rmagick/rmagick#256

Closed

Homebrew locked and limited conversation to collaborators May 4, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add back the old imagemagick under the name imagemagick@6 #8756

Add back the old imagemagick under the name imagemagick@6 #8756

crazymykl commented Jan 12, 2017 •

edited

Loading

ilovezfs commented Jan 12, 2017

zmwangx commented Jan 12, 2017 •

edited

Loading

ilovezfs commented Jan 12, 2017

zmwangx commented Jan 12, 2017

ilovezfs commented Jan 12, 2017

zmwangx commented Jan 12, 2017

ilovezfs commented Jan 12, 2017

zmwangx commented Jan 12, 2017

ilovezfs commented Jan 12, 2017

zmwangx commented Jan 12, 2017

ilovezfs commented Jan 12, 2017

crazymykl commented Jan 12, 2017

ilovezfs commented Jan 12, 2017

crazymykl commented Jan 12, 2017

ilovezfs commented Jan 12, 2017

zmwangx commented Jan 12, 2017

crazymykl commented Jan 12, 2017

jacquerie commented Jan 14, 2017 •

edited

Loading

MikeMcQuaid commented Jan 16, 2017

crazymykl Jan 16, 2017

crazymykl commented Jan 16, 2017

MikeMcQuaid Jan 16, 2017

MikeMcQuaid Jan 16, 2017

MikeMcQuaid Jan 16, 2017

MikeMcQuaid Jan 16, 2017

crazymykl commented Jan 16, 2017

MikeMcQuaid commented Jan 17, 2017

MikeMcQuaid commented Jan 17, 2017

Add back the old imagemagick under the name imagemagick@6 #8756

Add back the old imagemagick under the name imagemagick@6 #8756

Conversation

crazymykl commented Jan 12, 2017 • edited Loading

ilovezfs commented Jan 12, 2017

zmwangx commented Jan 12, 2017 • edited Loading

ilovezfs commented Jan 12, 2017

zmwangx commented Jan 12, 2017

ilovezfs commented Jan 12, 2017

zmwangx commented Jan 12, 2017

ilovezfs commented Jan 12, 2017

zmwangx commented Jan 12, 2017

ilovezfs commented Jan 12, 2017

zmwangx commented Jan 12, 2017

ilovezfs commented Jan 12, 2017

crazymykl commented Jan 12, 2017

ilovezfs commented Jan 12, 2017

crazymykl commented Jan 12, 2017

ilovezfs commented Jan 12, 2017

zmwangx commented Jan 12, 2017

crazymykl commented Jan 12, 2017

jacquerie commented Jan 14, 2017 • edited Loading

MikeMcQuaid commented Jan 16, 2017

crazymykl Jan 16, 2017

Choose a reason for hiding this comment

crazymykl commented Jan 16, 2017

MikeMcQuaid Jan 16, 2017

Choose a reason for hiding this comment

MikeMcQuaid Jan 16, 2017

Choose a reason for hiding this comment

MikeMcQuaid Jan 16, 2017

Choose a reason for hiding this comment

MikeMcQuaid Jan 16, 2017

Choose a reason for hiding this comment

crazymykl commented Jan 16, 2017

MikeMcQuaid commented Jan 17, 2017

MikeMcQuaid commented Jan 17, 2017

crazymykl commented Jan 12, 2017 •

edited

Loading

zmwangx commented Jan 12, 2017 •

edited

Loading

jacquerie commented Jan 14, 2017 •

edited

Loading