Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boost-build 1.78.0 #91225

Closed
wants to merge 1 commit into from
Closed

boost-build 1.78.0 #91225

wants to merge 1 commit into from

Conversation

SMillerDev
Copy link
Member

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Dec 13, 2021
@iMichka
Copy link
Member

iMichka commented Dec 13, 2021

/opt/homebrew/Cellar/boost-build/1.78.0/bin and especially /opt/homebrew/Cellar/boost-build/1.78.0/bin/b2 are not being installed, which makes the test fail. Weird.

@SMillerDev
Copy link
Member Author

They don't even exist after the build

@iMichka
Copy link
Member

iMichka commented Dec 13, 2021

Maybe the "known issues" and the patch is related? https://www.boost.org/users/history/version_1_78_0.html

@SMillerDev SMillerDev mentioned this pull request Dec 16, 2021
Closed
3 tasks
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Dec 18, 2021
Bo98
Bo98 reviewed Dec 18, 2021
View reviewed changes
Formula/boost-build.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot closed this Dec 19, 2021
@iMichka iMichka reopened this Dec 21, 2021
iMichka
iMichka approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@iMichka iMichka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we go; fixed. Let's ship this.

@iMichka iMichka removed the stale No recent activity label Dec 21, 2021
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Jan 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 left review comments

@iMichka iMichka iMichka approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SMillerDev @iMichka @BrewTestBot @Bo98