Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libwebsockets 4.3.1 #93354

Closed
wants to merge 3 commits into from
Closed

libwebsockets 4.3.1 #93354

wants to merge 3 commits into from

Conversation

Porkepix
Copy link
Contributor

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Jan 18, 2022
@carlocab
Copy link
Member 

  CMake Error at /opt/homebrew/lib/cmake/libwebsockets/libwebsockets-config.cmake:35 (include):
    include could not find requested file:
  
      LwsCheckRequirements

I think they might have shipped a broken .cmake file.

@carlocab
Copy link
Member

No, I take that back:

❯ fd cmake
libwebsockets/4.3.1/lib/cmake
libwebsockets/4.3.1/lib/cmake/libwebsockets/LibwebsocketsTargets-release.cmake
libwebsockets/4.3.1/lib/cmake/libwebsockets/LibwebsocketsTargets.cmake
libwebsockets/4.3.1/lib/cmake/libwebsockets/LwsCheckRequirements.cmake
libwebsockets/4.3.1/lib/cmake/libwebsockets/libwebsockets-config-version.cmake
libwebsockets/4.3.1/lib/cmake/libwebsockets/libwebsockets-config.cmake

@carlocab
libwebsockets: use a tarball instead of a Git clone
fd529a7 
Also, let's use more modern `cmake` syntax.
SMillerDev
SMillerDev approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea how this could fix things but sure!

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@Porkepix Porkepix deleted the bump-libwebsockets-4.3.1 branch January 19, 2022 15:21
carlocab
carlocab reviewed Jan 19, 2022
View reviewed changes
Formula/ttyd.rb
system "make", "install"
system "cmake", "-S", ".", "-B", "build",
"-DOPENSSL_ROOT_DIR=#{Formula["openssl@1.1"].opt_prefix}",
"-Dlibwebsockets_DIR=#{Formula["libwebsockets"].opt_lib/"cmake/libwebsockets"}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SMillerDev This is the fix. Everything else is just refactoring

@github-actions github-actions bot added the outdated PR was locked due to age label Feb 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab left review comments

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Porkepix @carlocab @BrewTestBot @SMillerDev @nandahkrishna