sdl2_ttf: avoid vendored freetype and harfbuzz #94505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2 tasks
2 tasks
BrewTestBot
added
the
automerge-skip
SMillerDev
previously approved these changes
Feb 5, 2022
This formula has a `freetype` dependency, but it's currently unused since it will use a vendored `freetype` by default. Since we're fixing this, let's also try to avoid using its vendored `harfbuzz` too. Closes Homebrew#94541.
This is needed for Homebrew#94505. The conflict comes from `freedink` depending on `python@3.10` and `python@3.9` through `cxxtest` and `glib` respectively. `cxxtest` is installed into a virtualenv in `libexec`, so it's unlikely that `freedink` actually makes use of anything there since it ships no Python code itself. An alternative to this is to migrate `glib` to `python@3.10`, which will take quite a while (see Homebrew#87277), or migrate `cxxtest` back to `python@3.9`, which is unnecessary. I've tested `freedink` locally and it seems to work fine despite the mixed recursive dependency. See also Homebrew#65831.
carlocab
added
CI-long-timeout
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?This formula has a
freetypedependency, but it's currently unusedsince it will use a vendored
freetypeby default. Since we're fixingthis, let's also try to avoid using its vendored
harfbuzztoo.