haskell-stack: Fix building from source, add Apple Silicon support

[simnalamburt]

1. Fixed building from source.

   Due to recent update of aeson-2.0.0.0, stack can no longer be built with cabal-install. So I patched stack to freeze cabal dependencies using stackage 17.15 LTS.

2. Add Apple Silicon support.

   HEAD version of stack has already been patched to support Apple Silicon. However, the next release containing that patch hasn't release yet. So I manually patched stack v2.7.3 to support Apple Silicon.

3. Add llvm@12 as a dependency only on ARM

   All ghc versions before 9.2.1 requires LLVM Code Generator as a backend on ARM.

Fixes #94796

References:

• stack setup installs GHC for aarch64 on M1 Macs commercialhaskell/stack#5562
• Fix cabal build by freezing cabal dependencies commercialhaskell/stack#5677

Checklists:

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• brew install --build-from-source --formula ./haskell-stack.rb
• brew test ./haskell-stack.rb
• brew audit --strict haskell-stack
• brew install --build-from-source --HEAD --formula ./haskell-stack.rb

[simnalamburt]

For those who want to use this patch right now:

brew install simnalamburt/x/haskell-stack

Reference

• https://github.com/simnalamburt/homebrew-x/

[xtendo-org]

@carlocab I'd really, really appreciate if you could merge this PR.

At this point, brew install haskell-stack on Apple Silicon machines is just ... broken. brew install seemingly does "something", but afterwards, the GHC tool chain doesn't work, leaving users puzzled. In fact, for users of M1* machines, at this point, there is no hassle-free way to use the Haskell Stack at all.

Well, as the PR author mentioned, there is brew install simnalamburt/x/haskell-stack, but this is obviously not what we want to recommend to all newcomers, and users will probably try brew install haskell-stack anyway, so leaving it broken will simply confuse and deter them. I think this is bad for both for brew and Haskell.

Stack provides their own installation method (distribution of binary executables) but they haven't released the version 2.7.4 that supports the Apple Silicon arch. Users will have to wait indefinitely. Besides, regardless of Stack's own release policy, brew install should work, right?

As you pointed out, the patch size (in terms of bytes) is pretty big, but what it does is actually small and simple: Freeze the versions of dependency packages in the build process. Hopefully Stack will solve the "dependency version problem when building with cabal" issue, at which point we can probably ditch this patch. Furthermore, since this is in the patch do ~ end form, we should be able to remove it easily in the future.

I think this serves as a really nice stopgap for Apple Silicon users right now. Please merge this. I beg you.

[SMillerDev]

Besides, regardless of Stack's own release policy, brew install should work, right?

Generally brew just ships what upstream ships and almost everywhere in our documentation we tell people not to patch things in brew (but to fix it upstream). If upstream doesn't feel comfortable releasing this patch yet I'm not sure if we should.

[carlocab]

Thanks!

[BrewTestBot]

❌ @carlocab bottle request for cedille failed.

[BrewTestBot]

❌ @carlocab bottle request for psc-package failed.

[simnalamburt]

@carlocab Since I wrote this PR, I’m willing to help you if this PR caused any issue with bottling haskell-stack or others.

[carlocab]

haskell-stack bottled fine. The messages you're seeing are for (recursive) dependents. At least one of them looks to have been broken by aeson. I don't think any of these failures are due to this PR. (Indeed, we wouldn't even have been able to attempt to bottle them without this.)

[simnalamburt]

I just checked 87ec35b. Thanks!

Can you rebuild the “arm64_big_sur” image too? The existing arm64_big_sur binary does not work properly without this PR. It will enable other haskell-stack dependents’ arm64_big_sur builds too!

[carlocab]

Can you explain the problem with the arm64_big_sur bottle, and give a minimal reproduction? We haven't had any issues using the existing haskell-stack build to build other formulae on Big Sur (and there have been a few of those recently).

[simnalamburt]

WIth existing binary:

brew install haskell-stack
cd any-stack-project # navigate into any stack project
stack setup

Will fail with I don't know how to install GHC for (OSX,AArch64), please install manually..

This issue was fixed by commercialhaskell/stack#5562. This is the reason why I patched haskell-stack with e3910ed#diff-7262ae90068953c6fc17eb4ec7deac3a69c7edf2ed4e32edc4ce2e4dc00d73dfR22-R31.

[simnalamburt]

Actually this is what @xtendo-org meant by "brew install seemingly does "something", but afterwards, the GHC tool chain doesn't work, leaving users puzzled.". On ARM Big Sur, brew install haskell-stack does install you some binaries but all stack commands like stack setup, stack ghci, stack build, etc won't work.

[carlocab]

We should've bumped the revision, then. Feel free to open a new PR that does so.

[simnalamburt]

Got it!