ltex-ls 15.2.0 (new formula)

[gzagatti]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[gzagatti]

CI raises the following error:

  Error:  Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:3.0.0:run (add-ltex-cli) on project ltexls: An Ant BuildException has occured: Execute failed: java.io.IOException: Cannot run program "python" (in directory "/tmp/ltex-ls-20220225-20481-8duwhb/ltex-ls-15.2.0"): error=2, No such file or directory
  Error:  around Ant part ...<exec executable="python">... @ 4:31 in /tmp/ltex-ls-20220225-20481-8duwhb/ltex-ls-15.2.0/target/antrun/build-main.xml
  Error:  -> [Help 1]

However, I'm not able to reproduce it in my local machine as the formula builds with no problem.

[branchvincent]

it seems this relies on a python executable being available: https://github.com/valentjn/ltex-ls/blob/4954220ebd34df6c032ca646fd9bab5bb4d8231e/pom.xml#L376

we can add one to PATH:

Suggested change

	ENV["JAVA_HOME"] = Formula["openjdk@11"].opt_prefix
	ENV.prepend_path "PATH", Formula["python@3.9"].opt_libexec/"bin"
	ENV["JAVA_HOME"] = Formula["openjdk@11"].opt_prefix

[branchvincent]

can this use python@3.10?

Suggested change

	depends_on "python@3.9" => :build
	depends_on "python@3.10" => :build

[gzagatti]

Thanks for your suggestion, they were very illuminating. I've implemented them. Let's see whether CI passes now.

[gzagatti]

The problem with the new build is that the command

system Formula["python@3.10"].bin/"python3", "-u", "tools/createCompletionLists.py"

Attempt to write completion lists in a temporary folder which is then unwrittable in CI. The source code is here

Invalid argument: Path is not writable: /var/folders/07/mmpkd6_x7fvbpl_msv10c7fh0000gp/T

Since the completion lists fail to write, the maven unit test that requires it then fails. I'm not sure if the completion lists are required for the application to work or it's only temporarily created for the unit tests.

In any case, I am pushing a build that does not execute the tests. Let's see how it does.

[gzagatti]

It turns out the completion list is necessary, but I figure out that by changing the environment variable TMPDIR in the build, I can get the completion list script to produce temporary directories in the build directory.

[gzagatti]

The problem in CI seems to be unrelated with the build process:

  Error: ltex-ls: no bottle available!
  You can try to install from source with:
    brew install --build-from-source ltex-ls
  Please note building from source is unsupported. You will encounter build
  failures with some formulae. If you experience any issues please create pull
  requests instead of asking for help on Homebrew's GitHub, Twitter or any other
  official channels.

I'm not sure how to overcome this. Any help would be appreciated.

[gzagatti]

The two CI processes fail because there is no bottle available. How can I create a bottle @branchvincent?

[branchvincent]

there is no bottle available

hmm, this is a confusing error but the reason is that openjdk@11 isn't bottled on Monterey. If it's possible, we can try building with openjdk

[gzagatti]

@branchvincent thanks for your comment. It was super helpful. I've made the modifications and the formula can build with openjdk without a problem. I hope that it now passes all CI test.

[SMillerDev]

  Invalid argument: Path is not writable: /var/folders/sd/fmj8vmcx7f32h_wz5tn7dy4c0000gp/T

It's trying to write outside of the install prefix

[gzagatti]

I forgot to fix JAVA_HOME when I updated openjdk. I’m glad that fixing it solved all the issues.

[gzagatti]

I'm just wondering if there is any expectation for review of this PR?

[gzagatti]

Thanks for revision! I closed the issue by mistake (the page refreshed with the mouse right on top of the close button :( ) and then re-opened.

[SMillerDev]

Thanks @gzagatti ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

[gzagatti]

That's great news! Thanks for taking the time of reviewing the new formula and for maintaining Homebrew for the benefit of all. This is one piece of software that has followed me through my whole computer journey.

[BrewTestBot]

@SMillerDev has triggered a merge.