spidermonkey @ 1486087028 #9607
Conversation
|
Do not merge this yet! Let’s see where the discussion on https://bugzilla.mozilla.org/show_bug.cgi?id=1336514 goes first. |
| bin.install "shell/js" | ||
| end | ||
| lib.install "libmozglue.dylib", "libnss3.dylib" | ||
| bin.install "js" => "spidermonkey" |
There was a problem hiding this comment.
Ideally, this would be aliased as sm in addition to spidermonkey. What’s the best way to do that within a formula? bin.install "js" => "spidermonkey", "js" => "sm" doesn’t seem to work.
There was a problem hiding this comment.
bin.install "js" => "spidermonkey"
bin.install_symlink "spidermonkey" => "sm"
Formula/spidermonkey.rb
Outdated
| @@ -1,54 +1,17 @@ | |||
| class Spidermonkey < Formula | |||
| desc "JavaScript-C Engine" | |||
| desc "SpiderMonkey is Mozilla's JavaScript engine, as used in Firefox" | |||
There was a problem hiding this comment.
We can use desc "Mozilla's JavaScript engine, as used in Firefox" not to repeat the formula’s name.
There was a problem hiding this comment.
Thanks! Updated.
|
|
||
| depends_on "readline" | ||
| depends_on "nspr" | ||
| url "https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-release-macosx64/1486087028/jsshell-mac.zip" |
There was a problem hiding this comment.
We need to build from source.
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah, I found https://github.com/Homebrew/brew/blob/master/docs/Acceptable-Formulae.md#we-dont-like-binary-formulae which explains this requirement a bit further. Feel free to close this PR — I’ll create a tap instead.
There was a problem hiding this comment.
Tap with formulae for ECMAScript/JavaScript engines (downloaded from official sources instead of built from source, for performance reasons): https://github.com/mathiasbynens/homebrew-ecmascript
There was a problem hiding this comment.
Why is performance better when not build from source?
There was a problem hiding this comment.
@MikeMcQuaid I meant brew install spidermonkey is much faster if all you need to do is download a tarball and extract it, compared to building the exact same binary from source.
There was a problem hiding this comment.
We build binary packages for people for this same reason.
There was a problem hiding this comment.
Which in this case is cellar :any so can be used by anyone using the latest three versions of macOS
There was a problem hiding this comment.
mathiasbynens
force-pushed
the
patch-2
branch
from
7a32e8e
to
0dbb0bc
Compare
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?The existing SpiderMonkey formula builds a heavily outdated version from source. This new formula installs a more recent version by downloading a precompiled binary off the official servers.