emscripten 3.1.6 #96406
Closed
emscripten 3.1.6 #96406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrewTestBot
added
bump-formula-pr
carlocab
added
the
resource updates needed
carlocab
force-pushed
the
bump-emscripten-3.1.6
branch
from
0c68402
to
dc49be6
Compare
carlocab
removed
the
resource updates needed
BrewTestBot
added
the
automerge-skip
1. Use the `install_prefix` kwarg for `std_cmake_args`. 2. Avoid hardcoding the executables we pass to `write_env_script`. 3. Don't pass `CMAKE_LINKER` to the LLVM build. 4. Invoke `make` through `cmake` when building `binaryen`. 5. Don't use `ENV.cxx11`.
The conflict comes from the version of Python used by `node`, but this conflict is not a problem. (In fact, Node uses the first `python3` that a user has in their `PATH` on macOS with no problems.)
carlocab
force-pushed
the
bump-emscripten-3.1.6
branch
from
dc49be6
to
89d47ab
Compare
carlocab
reviewed
Mar 7, 2022
Comment on lines
+71
to
+77
| emscripts = buildpath.children.select do |pn| | ||
| next false unless pn.file? | ||
| next false unless pn.executable? | ||
| next false if pn.extname == ".py" && pn.basename(".py").exist? | ||
|
|
||
| true | ||
| end.map(&:basename) |
There was a problem hiding this comment.
Open to suggestions for simplifying this, but I'm opposed to continuing to hardcode this. Our current hardcoded list features a non-existent emlink.py, and is missing embuilder, emdump, emdwp, emnm, emprofile, emsize, and emsymbolizer.py.
carlocab
added
CI-long-timeout
carlocab
force-pushed
the
bump-emscripten-3.1.6
branch
from
dfb961d
to
20c9f0d
Compare
carlocab
added
ready to merge
SMillerDev
approved these changes
Mar 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.resourceblocks may require updates.