Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet 6.0.103 #96612

Closed
wants to merge 1 commit into from
Closed

dotnet 6.0.103 #96612

wants to merge 1 commit into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Mar 9, 2022

Created with brew bump-formula-pr.


dotnet/source-build#2789

  • Patch will need to be rebased.
  • There is potentially an option to reduce disk space requirement [Alpine Linux] Dotnet6 package dotnet/source-build#2782 (comment) which may allow us to reduce self-hosted runner size

    /p:CleanWhileBuilding=true

    Here is how it used in source-build CI.

    This options performs some cleanup logic after each repo is built.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` long build Set a long timeout for formula testing labels Mar 9, 2022
@cho-m cho-m added CI-linux-self-hosted Build on Linux self-hosted runner in progress Stale bot should stay away labels Mar 9, 2022
@cho-m cho-m force-pushed the bump-dotnet-6.0.103 branch 2 times, most recently from 65976d5 to 072c476 Compare March 10, 2022 05:34
<!-- There's no nuget package for runtime.linux-musl-x64.runtime.native.System.IO.Ports
<PackageReference Include="runtime.linux-musl-x64.runtime.native.System.IO.Ports" Version="$(RuntimeLinuxX64RuntimeNativeSystemIOPortsVersion)" />
-->
+ <PackageReference Include="runtime.osx-arm64.Microsoft.NETCore.ILAsm" Version="$(RuntimeLinuxX64MicrosoftNETCoreILAsmVersion)" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some issues trying to get RuntimeOsxArm64MicrosoftNETCoreILAsmVersion locally. Ended up needing to use Linux version for macOS ARM too

@cho-m cho-m added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed do not merge in progress Stale bot should stay away labels Mar 10, 2022
@cho-m cho-m added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Mar 10, 2022
@carlocab carlocab removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 10, 2022
Comment on lines 62 to 64
inreplace Dir["src/installer.*/src/redist/targets/GenerateLayout.targets"].first,
"$(MicrosoftAspNetCoreAppRuntimePackageVersion)",
"$(MicrosoftAspNetCoreAppRuntimewinx64PackageVersion)"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needed on Intel macOS. Doesn't seem to impact ARM macOS.

@cho-m cho-m added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 10, 2022
@nandahkrishna nandahkrishna removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 10, 2022
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@cho-m cho-m deleted the bump-dotnet-6.0.103 branch April 2, 2022 23:18
@github-actions github-actions bot added the outdated PR was locked due to age label May 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants