Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parent directory during installation #17

Merged
merged 314 commits into from
Nov 1, 2019

Conversation

cenksoykan
Copy link
Contributor

Root directory has to be brew temporary folder in formulae

@tani
Copy link
Member

tani commented Nov 1, 2019

I checked that these Formulae work fine, and I got a result that seems pretty good.
After the merging process, I will close #16. I really appreciate your contributions.
Thank you for working hard on this issue we have had for a long time.

@tani tani merged commit 1a24387 into Homebrew:master Nov 1, 2019
This was referenced Nov 1, 2019
@cenksoykan
Copy link
Contributor Author

Excellent 🕺 I'm so glad we fixed the issue. Even though I don't know ruby, definitely I've learned some. I like this project. Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants