Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

portable-ruby@2.2 links to Homebrew libraries on macOS #31

Closed
xu-cheng opened this issue Apr 13, 2017 · 3 comments
Closed

portable-ruby@2.2 links to Homebrew libraries on macOS #31

xu-cheng opened this issue Apr 13, 2017 · 3 comments
Labels
outdated

Comments

@xu-cheng
Copy link
Member 

$ brew linkage portable-ruby@2.2
System libraries:
  /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
  /usr/lib/libSystem.B.dylib
  /usr/lib/libncurses.5.4.dylib
  /usr/lib/libobjc.A.dylib
  /usr/lib/libutil.dylib
  /usr/lib/libz.1.dylib
Homebrew libraries:
  /usr/local/opt/libyaml/lib/libyaml-0.2.dylib (libyaml)
Possible undeclared dependencies:
  libyaml

As shown above, portable-ruby@2.2 will accidentally link to Homebrew library (libyaml) instead of portable-yaml. Test is done on macOS 10.12.

cc @mistydemeo
@xu-cheng
Copy link
Member Author

xu-cheng commented Apr 13, 2017 •
edited

Test shows this is caused by 6ce1fb3.

I suspect the cause is because make method bypasses superenv.

@mistydemeo
Copy link
Member

Good catch - I missed this! Tiger doesn't have superenv yet, so I didn't notice it in that environment.

This should probably be set to just run make or gmake, not the full path, and as long as the Homebrew-installed make is before /usr/bin in the PATH, it should be fine.

mistydemeo added a commit to mistydemeo/brew that referenced this issue Apr 15, 2017
@mistydemeo
FileUtils.make: don't bypass superenv
31cbcd0 
The intention here was to make sure that `make` or `gmake` is called as
appropriate; as long as paths are set up right, superenv shims should
call through to the Homebrew copy as appropriate.

Fixes Homebrew/homebrew-portable-ruby#31.
@mistydemeo mistydemeo mentioned this issue Apr 15, 2017
Closed
4 tasks
@mistydemeo
Copy link
Member

Fixed via Homebrew/brew#2883.

@lock lock bot added the outdated label Jan 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mistydemeo @xu-cheng