Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portable Ruby 3.3.1 #190

Merged
merged 1 commit into from
May 16, 2024
Merged

Portable Ruby 3.3.1 #190

merged 1 commit into from
May 16, 2024

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented May 15, 2024

Maybe we want 3.2 instead but 3.3 seems reasonable for us to at least try out.

Also remove unneeded dependencies.

Closes #189

@Bo98
Copy link
Member

Bo98 commented May 15, 2024

libedit and ncurses(?) I think can be deleted entirely if we're definitely going for 3.3.

We should decide what the update strategy here is going forward. Last time the idea was x.(y - 1).z on Aprils. Maybe the strategy now is latest x.y.z when z >= 1.

@MikeMcQuaid
Copy link
Member Author

We should decide what the update strategy here is going forward. Last time the idea was x.(y - 1).z on Aprils. Maybe the strategy now is latest x.y.z when z >= 1.

Yeh, Ruby minor releases are stable enough now that 3.3.1 seems pretty rock solid in my use elsewhere.

I like the idea of x.y.(z >=1) as you've said (and ideally start tracking the patch releases too).

@MikeMcQuaid
Copy link
Member Author

libedit and ncurses(?) I think can be deleted entirely if we're definitely going for 3.3.

Done!

@MikeMcQuaid MikeMcQuaid requested a review from Bo98 May 15, 2024 12:47
@MikeMcQuaid MikeMcQuaid marked this pull request as ready for review May 15, 2024 12:48
@Bo98
Copy link
Member

Bo98 commented May 15, 2024

I like the idea of x.y.(z >=1) as you've said (and ideally start tracking the patch releases too).

This is nice since I was wanting to add autobump and something like this can be nicely algorithmically picked in a livecheck block.

Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MJIT_CC I think can be removed too since MJIT is no more but LGTM otherwise

@MikeMcQuaid
Copy link
Member Author

MJIT_CC I think can be removed too

Good idea, done!

@carlocab
Copy link
Member

carlocab commented May 15, 2024

brew tests is looking good for me with 3.3.1. Only failure seems unrelated:

Failures:

  1) Cask::Artifact::App install_phase when the target already exists given the force option target is user-owned but contains read-only files overwrites the existing app
     Failure/Error: let(:install_phase) { app.install_phase(command:, adopt:, force:) }

     ErrorDuringExecution:
       Failure while executing; `/usr/bin/env touch /private/tmp/homebrew-tests-20240515-52974-mimh8r/cask-appdir/Caffeine.app/.homebrew-write-test` exited with 1. Here's the output:
       touch: /private/tmp/homebrew-tests-20240515-52974-mimh8r/cask-appdir/Caffeine.app/.homebrew-write-test: Permission denied
     # ./system_command.rb:352:in `assert_success!'
     # ./system_command.rb:75:in `run!'
     # ./system_command.rb:40:in `run'
     # ./test/support/helper/cask/never_sudo_system_command.rb:8:in `run'
     # ./system_command.rb:44:in `run!'
     # ./cask/quarantine.rb:236:in `app_management_permissions_granted?'
     # ./cask/artifact/moved.rb:107:in `move'
     # ./cask/artifact/moved.rb:17:in `install_phase'
     # ./test/cask/artifact/app_spec.rb:13:in `block (2 levels) in <top (required)>'
     # ./test/cask/artifact/app_spec.rb:185:in `block (7 levels) in <top (required)>'
     # ./test/cask/artifact/app_spec.rb:185:in `block (6 levels) in <top (required)>'
     # ./test/support/helper/spec/shared_context/homebrew_cask.rb:64:in `block (2 levels) in <top (required)>'
❯ brew config | rg 'Homebrew Ruby'
Homebrew Ruby: 3.3.1 => /Users/carlocab/.rbenv/versions/3.3.1/bin/ruby

@MikeMcQuaid MikeMcQuaid merged commit 9c76001 into master May 16, 2024
5 checks passed
@MikeMcQuaid MikeMcQuaid deleted the 3.3.1 branch May 16, 2024 01:38
@MikeMcQuaid
Copy link
Member Author

Thanks for help @carlocab and @Bo98!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants