Should check for unlinked dependencies of all dependents, not just named formulae

[scpeters]

While investigating CI failures in Homebrew/homebrew-core#67615 (applying an upstream patch to boost), I noticed that brew test pcl failed for all architectures, even though it had passed very recently in Homebrew/homebrew-core#66792. The tests in Homebrew/homebrew-core#67615 failed to find eigen when running cmake to configure some sample code that links against pcl. Searching earlier in the console log, I noticed brew unlink eigen just before freeling was tested. Looking at the console logs from Homebrew/homebrew-core#66792, I noticed the same call to brew unlink eigen just before freeling, but there was also a call to brew link eigen just before pcl was handled. The difference between those two pull requests is that pcl received a revision bump in the earlier one, and there is logic in setup_formulae_deps_instances() in lib/tests/formulae.rb that calls brew link on unlinked dependencies for any formulae to be built. I believe this logic should be added to link dependencies for any dependents that are installed, not just the explicitly named formulae to be tested.

[MikeMcQuaid]

The difference between those two pull requests is that pcl received a revision bump in the earlier one, and there is logic in setup_formulae_deps_instances() in lib/tests/formulae.rb that calls brew link on unlinked dependencies for any formulae to be built. I believe this logic should be added to link dependencies for any dependents that are installed, not just the explicitly named formulae to be tested.

Makes sense to me @scpeters! Could you open a PR?

[scpeters]

The difference between those two pull requests is that pcl received a revision bump in the earlier one, and there is logic in setup_formulae_deps_instances() in lib/tests/formulae.rb that calls brew link on unlinked dependencies for any formulae to be built. I believe this logic should be added to link dependencies for any dependents that are installed, not just the explicitly named formulae to be tested.

Makes sense to me @scpeters! Could you open a PR?

I'll work up the courage and give it a shot 😅

[BrewTestBot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[scpeters]

potential fix in #659