formula_dependents: ensure dependencies are linked #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
reviewed
Sep 2, 2021
bayandin
force-pushed
the
link-dependencies
branch
from
6e59cf0
to
1b61250
Compare
scpeters
reviewed
Sep 2, 2021
bayandin
force-pushed
the
link-dependencies
branch
from
1b61250
to
7164c8a
Compare
bayandin
force-pushed
the
link-dependencies
branch
from
7164c8a
to
f0cc84f
Compare
carlocab
approved these changes
Sep 3, 2021
dawidd6
approved these changes
Sep 3, 2021
|
Thanks @bayandin! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that we have all dependencies (runtime and test) linked while we test a formula.
Here's an original issue:
A,BandC:Aconflicts withB;Cdepends onBBwhile testingA(as a conflicting one)C,Bis still unlinked, and this could lead to a test failure forCWe got exactly this situation in
Fixes #544
\cc @carlocab @scpeters