Delete unused code. #355
Merged
Delete unused code. #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we've decommissioned jenkins.brew.sh we can delete all Jenkins related code. While doing this, audit remaining code to ensure that all methods, parameters, environment variables and configurations are those used and supported by Homebrew.
Bo98
reviewed
Apr 19, 2020
| @@ -1124,7 +994,6 @@ def run | |||
| ensure | |||
| cleanup_after | |||
| end | |||
| check_results | |||
There was a problem hiding this comment.
This line needs to stay (along with the implementation of check_results). run should return a boolean that indicates whether there were no failures.
Bo98
reviewed
Apr 20, 2020
Comment on lines
-761
to
+693
| if !Homebrew.args.fast? || formula_bottled || formula.bottle_unneeded? | ||
| if formula.bottled? || formula.bottle_unneeded? |
There was a problem hiding this comment.
This is a logic change. Previously this would always be true if --fast wasn't set. With this change, that is no longer the case.
This condition now evaluates to false for new formulae - they don't have a bottle block.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've decommissioned jenkins.brew.sh we can delete all Jenkins related code. While doing this, audit remaining code to ensure that all methods, parameters, environment variables and configurations are those used and supported by Homebrew.