formulae: adjust testing behaviour. #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when testing a formula as a dependent of another: retry the test on failures (requires Homebrew/brew#8135) - when testing a added/modified formula: - don't retry the test (we want to know if it's flaky) - don't try to test dependents if the test fails This should improve both the reliability and performance of PRs with large numbers of dependents.
Bo98
reviewed
Jul 30, 2020
| test "brew", "test", "--verbose", formula_name | ||
|
|
||
| steps.last.passed? |
There was a problem hiding this comment.
Considering it is called test_passed_or_missing, don't we want:
Suggested change
| steps.last.passed? | |
| steps.last.passed? | |
| else | |
| true |
There was a problem hiding this comment.
Yes, it was there in a previous iteration, I swear 😅.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve both the reliability and performance of PRs with large numbers of dependents.