Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-bot: install brewed curl if needed #653

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Aug 18, 2021

This is needed when using brewed curl to fetch and/or audit
formulae

See Homebrew/brew#11705

@request-info
Copy link

request-info bot commented Aug 18, 2021

Please provide a better issue/pull request title and/or description!

@iMichka
Copy link
Member Author

iMichka commented Aug 18, 2021

error: could not lock config file .git/config: Permission denied
Error: Command failed with exit 255: git

This is needed when using brewed curl to fetch and/or audit
formulae
@iMichka
Copy link
Member Author

iMichka commented Aug 18, 2021

This is ready for review. @MikeMcQuaid is there a place where I can ask it to uninstall curl when the tests are done?

@iMichka iMichka merged commit 73294dd into Homebrew:master Aug 19, 2021
@iMichka iMichka deleted the curl branch August 19, 2021 12:43
@iMichka
Copy link
Member Author

iMichka commented Aug 19, 2021

I merged this to test the change in homebrew-core. We can't use the new :using strategy before a new brew release is made anyway, so we have a little bit of time.

I would still want to explore the possibility to uninstall brewed curl at the end of the test run of each formula.

@MikeMcQuaid
Copy link
Member

I would still want to explore the possibility to uninstall brewed curl at the end of the test run of each formula.

@iMichka I think this should happen automatically with the existing code.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants