Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Commit

Permalink
travis: untap versions after ruby187 install
Browse files Browse the repository at this point in the history
  • Loading branch information
@DomT4
DomT4 committed Nov 22, 2015
1 parent d9d591a commit ad9cd44
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .travis.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ install:
brew install homebrew/versions/ruby187;
export PATH="/usr/local/opt/ruby187/bin:$PATH";
export HOMEBREW_RUBY_PATH="/usr/local/opt/ruby187/bin/ruby";
brew untap homebrew/versions;
fi
- export HOMEBREW_DEVELOPER="1"

Expand Down

10 comments on commit ad9cd44

@UniqMartin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! It got me thinking: We might want to create another Ruby 1.8.7 formula, possibly in a separate tap or hosted somewhere else to avoid having to tap homebrew/versions all the time. This dedicated formula should probably have its readline and openssl dependencies vendored in to avoid running into issues once a PR that touches one of these formulae comes along. It could also help prevent unwanted and unforeseen interactions with other formulae. (And I wonder where best to discuss this.)

@DomT4
Copy link
Member Author

@DomT4 DomT4 commented on ad9cd44 Nov 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to create an issue on your thoughts there, or join the maintainer team and comment in the chat 😜.

@UniqMartin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or join the maintainer team and comment in the chat 😜.

Might actually happen as I answered Mike's mail (sent last Friday) in the affirmative, i.e. agreeing to join. 😏

@DomT4
Copy link
Member Author

@DomT4 DomT4 commented on ad9cd44 Nov 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was that reply sent at 17:37 (UK time)?

@UniqMartin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it was sent at 17:13 +01:00 (CET), I guess 16:13 UK time.

@DomT4
Copy link
Member Author

@DomT4 DomT4 commented on ad9cd44 Nov 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Interesting. Thanks! Just curious about a slightly confusing email I got from the dev list at 17:37, heh.

Welcome to the team 🎉. Will leave Mike to deal with the bumping permissions, adding you to the chat etc, he usually handles that.

@UniqMartin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the team 🎉.

Thanks a bunch! I'm happy to join and hope I won't wreak havoc when first touching a repository used by thousands. 😉

@DomT4
Copy link
Member Author

@DomT4 DomT4 commented on ad9cd44 Nov 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's tradition for maintainers to break Homebrew at least once 😉

@MikeMcQuaid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@UniqMartin Apologies for the delay, my Homebrew backlog is long. I'll get to it/you ASAP ❤️

@UniqMartin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcQuaid No worries, take your time! Happy to hear that my response made it into your inbox.

Please sign in to comment.