superenv python shim breaks when used as a shebang

[jacknagel]

The superenv python shim does not work when used in the following way:

$ cat test
#!/usr/local/Library/ENV/4.3/python
import os
$ ./test
./test: line 2: import: command not found

This is because the shim is itself a script with a shebang and nested shebangs do not work.

This breaks some builds, for example gobject-introspection, which generates a python script with such a shebang.

[jacknagel]

I think the shim needs to go. I was working on a similar approach last year in #20118, but abandoned it after some discussion. Even if this bug wasn't a blocker, whitelisting executables seems like a Sisyphean task.

To fix the python stuff, we need to reinstate the original python-superenv fixes that went in shortly after superenv itself; 8f0c5f7 and 50417c1 are relevant.

[mistydemeo]

I think you're right, the shim isn't working. I'm going to revert it. Sorry I'd forgotten about the previous thread.

[mistydemeo]

Reverted in 6896f9d.

[MikeMcQuaid]

@jacknagel @mistydemeo On it. Should be relatively easy.