This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
Added beta to linklint formula #31977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you try and submit this upstream anyway, thanks. |
|
|
||
| # fix version number reported by linklint -version in beta | ||
| # note, upstream is abandoned, so inreplace instead of patch | ||
| inreplace "linklint-#{version}", "2.3.1", "#{version}" if build.devel? |
There was a problem hiding this comment.
"#{version}" should be version
|
ping |
…t does not need to be renamed. Install the README file in shared docs. Add test and patch to fix version reported from the beta.
keithws
force-pushed
the
linklint-devel
branch
from
85fc910
to
d6a2047
Compare
|
Fixed version and rebased. |
|
I emailed the original author with a patch to correct the version number. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed issues in #31079 after it was closed. I updated the test to write a file and run it through the program like the cmake test does. I also replace the patch with a simple "inreplace" line since the upstream is abandoned.