GDAL Java Swig bindings

[pauldaustin]

I'm looking at modifying the gdal build to be able to enable building the java bindings using swig.

One thing I've noticed is that there is some inconsistency in the naming of options in this script. Some use --enable-* and others use --with-*. Is there a preferred home-brew naming.

I was thinking that as there are other swig bindings (e.g. perl, php etc) that the options to enable them would be --enable-swig-* (e.g. --enable-swig-java).

Why not use --enable-java. The reason for this is that for some languages the main GDAL code can be compiled to support that language. The swig bindings are additional libraries that use the main GDAL library. In theory someone might want to compile GDAL to support python. But not have the python libraries to use GDAL.

I read the home-brew docs and it as easy as this to get this change into the code.

1. Fork homebrew
2. Edit the /usr/local/Library/Formula/gdal.rb
3. Update the revision number
4. Make other changes
5. Commit and push to my fork
6. Create pull request

The following code shows the diff from version 1.11.2_1.

<   option 'enable-swig-java', 'Build the swig java bindings'
74,75d72
<   depends_on 'swig'
< 
290,302d286
<     if 'enable-swig-java'
<       cd 'swig/java' do
<         system "echo 'JAVA_HOME='`/usr/libexec/java_home -v 1.7` > java.opt"
<         system "echo 'JAVADOC=$(JAVA_HOME)/bin/javadoc' >> java.opt"
<         system "echo 'JAVAC=$(JAVA_HOME)/bin/javac' >> java.opt"
<         system "echo 'JAVA=$(JAVA_HOME)/bin/java' >> java.opt"
<         system "echo 'JAR=$(JAVA_HOME)/bin/jar' >> java.opt"
<         system "echo 'JAVA_INCLUDE=-I$(JAVA_HOME)/include -I$(JAVA_HOME)/include/darwin' >> java.opt"
<         system "make"
<         system "make install"
<       end
<     end
< 

[MikeMcQuaid]

One thing I've noticed is that there is some inconsistency in the naming of options in this script. Some use --enable-* and others use --with-*. Is there a preferred home-brew naming.

Yup, the with form.

Otherwise: all sounds good!