-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
Conversation
depends_on 'enchant' => :optional if ARGV.include? '--enable-enchant' | ||
depends_on 'libotr' => :optional if ARGV.include? '--enable-otr' | ||
depends_on 'libidn' => :optional | ||
depends_on 'libotr' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this still be conditional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is, --enable-otr
is still listed as an option.
If the user builds head, libotr is required even if they --disable-otr, otherwise there's a configure error. |
Then as long as we're going to install it anyway, should we just be passing |
Yes I think we should throw --enable-otr by default. After reading the mcabberrc.example file, I found |
Define a couple of variables to help --HEAD run autogen.sh and locate our m4 macros. Adds a Dir.chdir for HEAD, and a depend_on libotr, otherwise configure will choke once you generate it and run it. Adds a caveat to inform the user how to setup their .mcabberrc configuration file. This compiles on Lion and Snow Lep with all five compilers, either stable or head. EDIT: changes --enable-otr from an option to being the default.
Let me know if that looks ok @jacknagel. I incorporated changes to make --enable-otr the default behavior. |
Looks good, pulling. |
Define a couple of variables to help --HEAD run autogen.sh and locate our m4 macros. Adds a Dir.chdir for HEAD, and a depend_on libotr, otherwise configure will choke once you generate it and run it. Adds a caveat to inform the user how to setup their .mcabberrc configuration file. This compiles on Lion and Snow Lep with all five compilers, either stable or head. Changes --enable-otr from an option to being the default. Closes Homebrew#10174. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Define a couple of variables to help --HEAD run autogen.sh and locate our m4 macros. Adds a Dir.chdir for HEAD, and a depend_on libotr, otherwise configure will choke once you generate it and run it. Adds a caveat to inform the user how to setup their .mcabberrc configuration file. This compiles on Lion and Snow Lep with all five compilers, either stable or head. Changes --enable-otr from an option to being the default. Closes Homebrew#10174. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Define a couple of variables to help --HEAD run autogen.sh
and locate our m4 macros. Adds a Dir.chdir for HEAD, and
a depend_on libotr, otherwise configure will choke once you
generate it and run it. Adds a caveat to inform the user
how to setup their .mcabberrc configuration file. This
compiles on Lion and Snow Lep with all five compilers,
either stable or head.
This is a fix for #10048