Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

mcabber - fixes for autogen.sh #10174

Closed
wants to merge 1 commit into from
Closed

mcabber - fixes for autogen.sh #10174

wants to merge 1 commit into from

Conversation

2bits
Copy link
Contributor

@2bits 2bits commented Feb 14, 2012

Define a couple of variables to help --HEAD run autogen.sh
and locate our m4 macros. Adds a Dir.chdir for HEAD, and
a depend_on libotr, otherwise configure will choke once you
generate it and run it. Adds a caveat to inform the user
how to setup their .mcabberrc configuration file. This
compiles on Lion and Snow Lep with all five compilers,
either stable or head.

This is a fix for #10048

depends_on 'enchant' => :optional if ARGV.include? '--enable-enchant'
depends_on 'libotr' => :optional if ARGV.include? '--enable-otr'
depends_on 'libidn' => :optional
depends_on 'libotr'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this still be conditional?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is, --enable-otr is still listed as an option.

@2bits
Copy link
Contributor Author

2bits commented Feb 15, 2012

If the user builds head, libotr is required even if they --disable-otr, otherwise there's a configure error.
I didn't feel like making an ugly conditional, as Mcabber is the only program that uses libotr,
and its compile time is 7 seconds. This way it also shows up in brew uses libotr too.

@jacknagel
Copy link
Contributor

Then as long as we're going to install it anyway, should we just be passing --enable-otr to configure by default?

@2bits
Copy link
Contributor Author

2bits commented Feb 15, 2012

Yes I think we should throw --enable-otr by default. After reading the mcabberrc.example file, I found
that after you --enable-otr, you still have to turn it on inside .mcabberrc. So we would be building a more
featured mcabber, but we would not be imposing otr. I will make another commit.

Define a couple of variables to help --HEAD run autogen.sh
and locate our m4 macros.  Adds a Dir.chdir for HEAD, and
a depend_on libotr, otherwise configure will choke once you
generate it and run it.  Adds a caveat to inform the user
how to setup their .mcabberrc configuration file.  This
compiles on Lion and Snow Lep with all five compilers,
either stable or head.

EDIT: changes --enable-otr from an option to being the default.
@2bits
Copy link
Contributor Author

2bits commented Feb 15, 2012

Let me know if that looks ok @jacknagel. I incorporated changes to make --enable-otr the default behavior.

@jacknagel
Copy link
Contributor

Looks good, pulling.

@jacknagel jacknagel closed this in f97f5a0 Feb 15, 2012
Sharpie pushed a commit to Sharpie/homebrew that referenced this pull request Sep 12, 2012
Define a couple of variables to help --HEAD run autogen.sh and locate
our m4 macros.  Adds a Dir.chdir for HEAD, and a depend_on libotr,
otherwise configure will choke once you generate it and run it.  Adds a
caveat to inform the user how to setup their .mcabberrc configuration
file.  This compiles on Lion and Snow Lep with all five compilers,
either stable or head.

Changes --enable-otr from an option to being the default.

Closes Homebrew#10174.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012
Define a couple of variables to help --HEAD run autogen.sh and locate
our m4 macros.  Adds a Dir.chdir for HEAD, and a depend_on libotr,
otherwise configure will choke once you generate it and run it.  Adds a
caveat to inform the user how to setup their .mcabberrc configuration
file.  This compiles on Lion and Snow Lep with all five compilers,
either stable or head.

Changes --enable-otr from an option to being the default.

Closes Homebrew#10174.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants