Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

htop: re-add of patched version of htop 0.8.2.1 #11727

Closed
wants to merge 1 commit into from

Conversation

max-horvath
Copy link
Contributor

Based on latest patches for version 0.8.2.1 of htop.

Compiles perfectly fine on Lion. Does not crash.

@MikeMcQuaid
Copy link
Member

This should probably be named htop-osx as it isn't the same as vanilla htop. Any chance of submitting some your patches upstream?

@rebelwarrior
Copy link

This is awesome. Thank you! htop is the tool I miss the most on my Mac OS X. Will this work on Snow Leopard too?

@sweenzor
Copy link

I am also excited for htop's return to os x!

@markalanevans
Copy link

+1

@erikformella
Copy link

yay!

@xer0x
Copy link

xer0x commented Apr 28, 2012

+1, anything stalling this from happening?

It feels kinda silly to install this using "git install https://raw.github.com/max-horvath/homebrew/htop/Library/Formula/htop.rb"

@scalp42
Copy link

scalp42 commented Apr 28, 2012

only reason I'm installing macport, would be great to have htop in the repo!

@ghost ghost assigned adamv Apr 28, 2012
@jgallen23
Copy link

when I try to run this I get: htop 0.8.2.1 aborted. Please report bug at http://htop.sf.net

osx 10.7.3
brew 0.9

@wadey
Copy link
Contributor

wadey commented May 2, 2012

This branch works great for me (and process memory size has finally been fixed). 👍 on the merge from me.

@markalanevans
Copy link

You know what would be a cool feature is if GitHub allow you to "Tip" a developer. Then instead of thumbs up we could tip like $1.00. To whomever pulled in the feature.

I suppose this would put the code at risk.. but man it would be nice. ;)

@sweenzor
Copy link

sweenzor commented May 2, 2012

kickstarting feature requests?

On Wed, May 2, 2012 at 1:25 PM, Mark Evans <
reply@reply.github.com

wrote:

You know what would be a cool feature is if GitHub allow you to "Tip" a
developer. Then instead of thumbs up we could tip like $1.00. To whomever
pulled in the feature.

I suppose this would put the code at risk.. but man it would be nice. ;)


Reply to this email directly or view it on GitHub:
#11727 (comment)

@markalanevans
Copy link

Yea! we could do +$$$ and it could say load up 3 dollars in a tip jar, to be cleared only when the feature was merged. ;)

@camillol
Copy link
Contributor

camillol commented May 2, 2012

Shouldn't the money go to the one who writes the patch, instead of to the one who pulls it?

@adamv
Copy link
Contributor

adamv commented May 2, 2012

The puller has got to get paid, son.

@xer0x
Copy link

xer0x commented May 2, 2012

@camillol totally, the person who submitted the pull request should be given the tip $.

I like the idea of cash tips, but to start with the money could be a credit towards the person's github subscription..

But this is getting off-topic, the topic is: Who do we need to bribe to get "htop-osx" into homebrew?

@MikeMcQuaid this should go in as "htop" because if htop ever merges in support for osx, then it would replace this package. This would making upgrading seamless.

@camillol
Copy link
Contributor

camillol commented May 2, 2012

Hm... Indeed, some pull requests still manage to make it through after only a few weeks. We do need an incentive for admins to keep them hostage for longer!

@adamv
Copy link
Contributor

adamv commented May 2, 2012

Make it htop-osx and add an htop alias.

@xer0x
Copy link

xer0x commented May 2, 2012

@adamv lmao

@MikeMcQuaid
Copy link
Member

I'll merge this when someone PayPals me $10.</joke>

@markalanevans
Copy link

Whats your paypal email? ;)

@MikeMcQuaid
Copy link
Member

GitHub stripped out the </joke> tag. My PayPal email is /dev/null

@markalanevans
Copy link

Ha. I wasn't. I'd send it to you. Doing a brew install htop vs hours of config a debug, $10 dollars is well worth it.

@sweenzor
Copy link

sweenzor commented May 3, 2012

if you're under the impression I'm above paying bribes for merges, you are
sorely mistaken.

On Wed, May 2, 2012 at 7:01 PM, Mike McQuaid <
reply@reply.github.com

wrote:

I'll merge this when someone PayPals me $10.


Reply to this email directly or view it on GitHub:
#11727 (comment)

@MikeMcQuaid
Copy link
Member

Save up your bribes until you can buy me something awesome like a island made of chocolate.

@apetresc
Copy link
Contributor

apetresc commented May 3, 2012

I've been running @max-horvath's recipe for a while without any problems. Gets a +1 from me.

@MikeMcQuaid
Copy link
Member

Added in 86cdaf8. Renamed to htop-osx, added an alias and removed the caveat which seemed unnecessary here. It can always be readded if necessary.

@MikeMcQuaid
Copy link
Member

Now everyone please PayPal me all your money so I can buy a boat.

@max-horvath If you can try and get this submitted upstream that would be awesome.

@sweenzor
Copy link

sweenzor commented May 3, 2012

✌️

On Wed, May 2, 2012 at 7:24 PM, Mike McQuaid <
reply@reply.github.com

wrote:

Now everyone please PayPal me all your money so I can buy a boat.

@max-horvath If you can try and get this submitted upstream that would be
awesome.


Reply to this email directly or view it on GitHub:
#11727 (comment)

@markalanevans
Copy link

Win! Mike You rock! HTOP Installed! Is your paypal email the one you use on GitHub?

@MikeMcQuaid
Copy link
Member

Please don't actually send me any money, seriously. It will change my motivations for working on Homebrew compared to my job. We might one day ask for donations to buy the Homebrew project e.g. some hardware or something. Hold out until then (if we ever do) and donate to the project. Thanks for your kind thoughts though :)

@markalanevans
Copy link

Put me on the list. You guys save me tons of time. ;)

@apetresc
Copy link
Contributor

apetresc commented May 3, 2012

Awesome, I'm glad to finally see it in!

However, I think the caveat is necessary. I see very different output when running it chmod'ed as root versus my normal account. I can post screenshots if others don't see it as well.

@MikeMcQuaid
Copy link
Member

@apetresc Fair enough, I'll re-add one.

MikeMcQuaid added a commit that referenced this pull request May 3, 2012
@MikeMcQuaid
Copy link
Member

Caveats added in 72346a6.

rohansingh pushed a commit to rohansingh/homebrew that referenced this pull request May 7, 2012
Closes Homebrew#11727.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
rohansingh pushed a commit to rohansingh/homebrew that referenced this pull request May 7, 2012
@ghost
Copy link

ghost commented May 9, 2012

htop installed just fine and runs, however if the terminal window gets beyond 117 in width OR 50 in height it crashes with the following error: htop 0.8.2.1 aborted. Please report bug at http://htop.sf.net

HOMEBREW_VERSION: 0.9
HEAD: 0235e58
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CELLAR: /usr/local/Cellar
CPU: dual-core 64-bit penryn
OS X: 10.7.4
Kernel Architecture: x86_64
Xcode: 4.3.2
GCC-4.0: N/A
GCC-4.2: N/A
LLVM: build 2336
Clang: 3.1 build 318
MacPorts or Fink? false
X11: /usr/X11
System Ruby: 1.8.7-357
/usr/bin/ruby => /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby
Which Perl: /usr/bin/perl
Which Python: /usr/bin/python
Which Ruby: /usr/bin/ruby => /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby

@adamv
Copy link
Contributor

adamv commented May 9, 2012

@max-horvath please update htop-osx with clear instructions to inform you when an abort occurs, thanks.

@max-horvath
Copy link
Contributor Author

Will do. I'm still on holidays.

@max-horvath please update htop-osx with clear instructions to inform you when an abort occurs, thanks.


Reply to this email directly or view it on GitHub:
#11727 (comment)

@douglascamata
Copy link

@Thatoneguy12 had this same issue, didn't test anything about the terminal window's size, but building it with anything else than clang (llvm-gcc or gcc) solved for me. Can you try this?

@adamv
Copy link
Contributor

adamv commented May 10, 2012

Please at least open a new issue here, instead of discussing on a closed one.

@douglascamata
Copy link

Already opened one issue about this: #12081

@max-horvath
Copy link
Contributor Author

Will fix ASAP ... thanks for the hint.

Already opened one issue about this: #12081


Reply to this email directly or view it on GitHub:
#11727 (comment)

@2bits
Copy link
Contributor

2bits commented May 10, 2012

sudo htop works perfectly for me on Lion with a 160x55 terminal window compiled with clang. I will on the other hand, take your money if you want me to say it's broken.

@max-horvath
Copy link
Contributor Author

Has been fixed with 255acfb ...

Sharpie pushed a commit to Sharpie/homebrew that referenced this pull request Sep 12, 2012
Closes Homebrew#11727.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
Sharpie pushed a commit to Sharpie/homebrew that referenced this pull request Sep 12, 2012
snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012
Closes Homebrew#11727.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012
@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.