This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
ENV: remove -L from CFLAGS. #13292
Closed
ENV: remove -L from CFLAGS. #13292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK/usr/include and lib now appended instead of prepended. Prepending overwrote our precedence of HOMEBREW_PREFIX/include and lib.
|
And we prefer this to manually fixing up formulae that only use CFLAGS (and submitting patches upstream?) |
|
@adamv Yes, I do. "-L" in CFLAGS is not so beautiful. Also it is harder to remove something from the CFLAGS than to add it. From my experience, only few formulae need this. But feel free to close this, if you disagree. |
Sharpie
pushed a commit
to Sharpie/homebrew
that referenced
this pull request
Jul 9, 2012
SDK/usr/include and lib now appended instead of prepended. Prepending overwrote our precedence of HOMEBREW_PREFIX/include and lib. Closes Homebrew#13292. Signed-off-by: Adam Vandenberg <flangy@gmail.com>
eproxus
pushed a commit
to eproxus/homebrew
that referenced
this pull request
Jul 18, 2012
SDK/usr/include and lib now appended instead of prepended. Prepending overwrote our precedence of HOMEBREW_PREFIX/include and lib. Closes Homebrew#13292. Signed-off-by: Adam Vandenberg <flangy@gmail.com>
snakeyroc3
pushed a commit
to snakeyroc3/homebrew
that referenced
this pull request
Dec 17, 2012
SDK/usr/include and lib now appended instead of prepended. Prepending overwrote our precedence of HOMEBREW_PREFIX/include and lib. Closes Homebrew#13292. Signed-off-by: Adam Vandenberg <flangy@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK/usr/include and lib now appended instead of prepended.
Prepending overwrote our precedence of HOMEBREW_PREFIX/include and lib.
This fixes #13225 and I can compile ruby now on a xcode_only system.